Xdev: Final Patches for Release #2818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean P. Goggins <[email protected]>
npm dependency patch
Signed-off-by: Sean P. Goggins <[email protected]>
Signed-off-by: Sean P. Goggins <[email protected]>
Signed-off-by: Sean P. Goggins <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1,5 +1,6 @@ | |||
| import requests | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0114: Missing module docstring (missing-module-docstring)
| @@ -212,7 +214,6 @@ def process_pull_request_review_contributor(pr_review: dict, tool_source: str, t | |||
|
|
|||
| return pr_review_cntrb | |||
|
|
|||
|
|
|||
| @celery.task(base=AugurSecondaryRepoCollectionTask) | |||
| def collect_pull_request_review_comments(repo_git: str) -> None: | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
R0914: Too many local variables (36/30) (too-many-locals)
| @@ -212,7 +214,6 @@ def process_pull_request_review_contributor(pr_review: dict, tool_source: str, t | |||
|
|
|||
| return pr_review_cntrb | |||
|
|
|||
|
|
|||
| @celery.task(base=AugurSecondaryRepoCollectionTask) | |||
| def collect_pull_request_review_comments(repo_git: str) -> None: | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
R0915: Too many statements (62/50) (too-many-statements)
| element.decode('utf-8').replace('\x00', ' ') if isinstance(element, bytes) else element | ||
| for element in page_data | ||
| ] | ||
| logger.info(f"NUL characters were found in PR Reviews and replaced with spaces.") |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation)
| logger.info(f"NUL characters were found in PR Reviews and replaced with spaces.") | ||
| elif isinstance(page_data, bytes): | ||
| page_data = page_data.decode('utf-8').replace('\x00', ' ') | ||
| logger.info(f"NUL characters were found in PR Reviews and replaced with spaces.") |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description