Move Facade Affiliation Refresh and Rebuild to Happen After Materialized Views Refresh #2820
Conversation
Signed-off-by: Isaac Milarsky <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -163,6 +166,36 @@ def refresh_materialized_views(self): | |||
| logger.info(f"error is {e}") | |||
| pass | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0107: Unnecessary pass statement (unnecessary-pass)
| @@ -4,6 +4,9 @@ | |||
|
|
|||
| from augur.tasks.init.celery_app import celery_app as celery | |||
| from augur.application.db.lib import execute_sql | |||
| from augur.tasks.git.util.facade_worker.facade_worker.config import FacadeHelper | |||
| from augur.tasks.git.util.facade_worker.facade_worker.rebuildcache import invalidate_caches, rebuild_unknown_affiliation_and_web_caches | |||
|
|
|||
|
|
|||
| @celery.task(bind=True) | |||
| def refresh_materialized_views(self): | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
R0912: Too many branches (19/12) (too-many-branches)
| @@ -4,6 +4,9 @@ | |||
|
|
|||
| from augur.tasks.init.celery_app import celery_app as celery | |||
| from augur.application.db.lib import execute_sql | |||
| from augur.tasks.git.util.facade_worker.facade_worker.config import FacadeHelper | |||
| from augur.tasks.git.util.facade_worker.facade_worker.rebuildcache import invalidate_caches, rebuild_unknown_affiliation_and_web_caches | |||
|
|
|||
|
|
|||
| @celery.task(bind=True) | |||
| def refresh_materialized_views(self): | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
R0915: Too many statements (96/50) (too-many-statements)
| @@ -10,8 +10,6 @@ | |||
| from augur.tasks.git.util.facade_worker.facade_worker.utilitymethods import get_absolute_repo_path, get_parent_commits_set, get_existing_commits_set | |||
| from augur.tasks.git.util.facade_worker.facade_worker.analyzecommit import analyze_commit | |||
| from augur.tasks.git.util.facade_worker.facade_worker.utilitymethods import get_repo_commit_count, update_facade_scheduling_fields, get_facade_weight_with_commit_count | |||
| from augur.tasks.git.util.facade_worker.facade_worker.rebuildcache import fill_empty_affiliations, invalidate_caches, nuke_affiliations, rebuild_unknown_affiliation_and_web_caches | |||
|
|
|||
|
|
|||
| from augur.tasks.github.facade_github.tasks import * | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0401: Wildcard import augur.tasks.github.facade_github.tasks (wildcard-import)
| @@ -140,8 +140,6 @@ def non_repo_domain_tasks(self): | |||
|
|
|||
| enabled_tasks = [] | |||
|
|
|||
| enabled_tasks.extend(generate_non_repo_domain_facade_tasks(logger)) | |||
|
|
|||
| if machine_learning_phase.__name__ in enabled_phase_names: | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
E0601: Using variable 'machine_learning_phase' before assignment (used-before-assignment)
| @@ -140,8 +140,6 @@ def non_repo_domain_tasks(self): | |||
|
|
|||
| enabled_tasks = [] | |||
|
|
|||
| enabled_tasks.extend(generate_non_repo_domain_facade_tasks(logger)) | |||
|
|
|||
| if machine_learning_phase.__name__ in enabled_phase_names: | |||
| #enabled_tasks.extend(machine_learning_phase()) | |||
| from augur.tasks.data_analysis.contributor_breadth_worker.contributor_breadth_worker import contributor_breadth_model | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0415: Import outside toplevel (augur.tasks.data_analysis.contributor_breadth_worker.contributor_breadth_worker.contributor_breadth_model) (import-outside-toplevel)
|
@IsaacMilarky : Is this ready? |
Yes sorry I think I forgot to make this a real PR. |
There was a problem hiding this comment.
@IsaacMilarky : Can you explain this one a little bit more.
| @@ -10,8 +10,6 @@ | |||
| from augur.tasks.git.util.facade_worker.facade_worker.utilitymethods import get_absolute_repo_path, get_parent_commits_set, get_existing_commits_set | |||
| from augur.tasks.git.util.facade_worker.facade_worker.analyzecommit import analyze_commit | |||
| from augur.tasks.git.util.facade_worker.facade_worker.utilitymethods import get_repo_commit_count, update_facade_scheduling_fields, get_facade_weight_with_commit_count | |||
| from augur.tasks.git.util.facade_worker.facade_worker.rebuildcache import fill_empty_affiliations, invalidate_caches, nuke_affiliations, rebuild_unknown_affiliation_and_web_caches | |||
There was a problem hiding this comment.
I think we want fill_empty_affiliations to still work.
Description
Notes for Reviewers
Hasn't been tested quite yet. I will make it a real PR when I have tested it.
Although feel free to test it yourself.
Signed commits