Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing import error #2825

Merged
merged 1 commit into from
Jun 20, 2024
Merged

fix missing import error #2825

merged 1 commit into from
Jun 20, 2024

Conversation

Ulincsys
Copy link
Contributor

Description

  • Temporary patch for required import to determine the frontend config location

Signed commits

  • Yes, I signed my commits.

@@ -0,0 +1,52 @@
import os

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
C0114: Missing module docstring (missing-module-docstring)

result[arg] = self[arg]
return result

def as_type(self, type, key):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0622: Redefining built-in 'type' (redefined-builtin)

@@ -1 +1,2 @@
from .LoginException import LoginException

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
C0114: Missing module docstring (missing-module-docstring)

Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sgoggins sgoggins merged commit 24da2cd into dev Jun 20, 2024
9 checks passed
@Ulincsys Ulincsys deleted the fix-missing-env branch June 21, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants