New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly identify iconized buttons using role attribute #2826

Merged

sgoggins merged 2 commits into dev from improve-frontend-accessibility

Jun 21, 2024

Contributor

Ulincsys commented Jun 21, 2024

Description

Makes the favorite/star buttons use a pointer cursor
Allows screen-reader users to identify buttons that were previously not visible to screen-reader software

Signed commits

Yes, I signed my commits.

Ulincsys added 2 commits

June 20, 2024 16:13


          Explicitly identify iconized buttons using role attribute

3a78d15

Signed-off-by: Ulincsys <[email protected]>


          Remove redundant button classification

42b5840

Signed-off-by: Ulincsys <[email protected]>

sgoggins approved these changes

View reviewed changes

Member

sgoggins left a comment

LGTM!

sgoggins merged commit b435122 into dev

9 checks passed

Ulincsys deleted the improve-frontend-accessibility branch

June 21, 2024 21:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet