Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev fixes #2828

Merged
merged 4 commits into from
Jun 24, 2024
Merged

Dev fixes #2828

merged 4 commits into from
Jun 24, 2024

Conversation

ABrain7710
Copy link
Contributor

Signed commits

  • Yes, I signed my commits.

@ABrain7710 ABrain7710 requested a review from sgoggins June 24, 2024 22:43
@@ -6,7 +6,12 @@


class RatelimitException(Exception):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
C0115: Missing class docstring (missing-class-docstring)


self.response = response

super().__init__(message)

class UrlNotFoundException(Exception):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
C0115: Missing class docstring (missing-class-docstring)

@@ -96,7 +101,7 @@ def make_request(self, url, method="GET", timeout=100):
response = client.request(method=method, url=url, timeout=timeout, follow_redirects=True)

if response.status_code in [403, 429]:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
R1720: Unnecessary "elif" after "raise", remove the leading "el" from "elif" (no-else-raise)

Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good TM!

@sgoggins sgoggins merged commit 4d574f2 into dev Jun 24, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants