Fix ml issue #2834
Fix ml issue #2834
Conversation
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -29,6 +29,8 @@ | |||
| from augur.tasks.git.util.facade_worker.facade_worker.utilitymethods import get_facade_weight_time_factor | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0413: Import "from augur.tasks.git.util.facade_worker.facade_worker.utilitymethods import get_facade_weight_time_factor" should be placed at the top of the module (wrong-import-position)
| @@ -29,6 +29,8 @@ | |||
| from augur.tasks.git.util.facade_worker.facade_worker.utilitymethods import get_facade_weight_time_factor | |||
| from augur.application.db.lib import execute_sql, get_session | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0413: Import "from augur.application.db.lib import execute_sql, get_session" should be placed at the top of the module (wrong-import-position)
| @@ -140,7 +142,9 @@ def non_repo_domain_tasks(self): | |||
|
|
|||
| enabled_tasks = [] | |||
|
|
|||
| if machine_learning_phase.__name__ in enabled_phase_names: | |||
| enabled_tasks.extend(generate_non_repo_domain_facade_tasks(logger)) | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
E0602: Undefined variable 'generate_non_repo_domain_facade_tasks' (undefined-variable)
| if machine_learning_phase.__name__ in enabled_phase_names: | ||
| enabled_tasks.extend(generate_non_repo_domain_facade_tasks(logger)) | ||
|
|
||
| if not RUNNING_DOCKER and machine_learning_phase.__name__ in enabled_phase_names: |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
E0601: Using variable 'machine_learning_phase' before assignment (used-before-assignment)
| if machine_learning_phase.__name__ in enabled_phase_names: | ||
| enabled_tasks.extend(generate_non_repo_domain_facade_tasks(logger)) | ||
|
|
||
| if not RUNNING_DOCKER and machine_learning_phase.__name__ in enabled_phase_names: | ||
| #enabled_tasks.extend(machine_learning_phase()) | ||
| from augur.tasks.data_analysis.contributor_breadth_worker.contributor_breadth_worker import contributor_breadth_model |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0415: Import outside toplevel (augur.tasks.data_analysis.contributor_breadth_worker.contributor_breadth_worker.contributor_breadth_model) (import-outside-toplevel)
This fixes #2767
Signed commits