Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add confirmation dialog for blank input in config script #2836

Merged
merged 2 commits into from
Jun 29, 2024
Merged

Add confirmation dialog for blank input in config script #2836

merged 2 commits into from
Jun 29, 2024

Conversation

Ulincsys
Copy link
Contributor

@Ulincsys Ulincsys commented Jun 28, 2024 •
edited
Loading

Description

  • Add confirmation prompt when user enters a blank line during config creation
  • Re-prompt until user answers affirmatively (IE: "yes"), or enters a non-blank value
  • Unify indentation of the config.sh script

This change should help to avoid entering blank values when extraneous newlines exist in standard input before execution of the config script.

Signed commits

  • Yes, I signed my commits.

@Ulincsys Ulincsys requested a review from sgoggins as a code owner June 28, 2024 12:58
sgoggins
sgoggins approved these changes Jun 29, 2024
View reviewed changes
Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sgoggins sgoggins merged commit bc547d9 into dev Jun 29, 2024
9 checks passed
@Ulincsys Ulincsys deleted the confirm-blank-input-make-install branch July 1, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgoggins sgoggins sgoggins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ulincsys @sgoggins