Migrate messages and events to use github data access #2837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -5,7 +5,7 @@ | |||
| from augur.tasks.init.celery_app import celery_app as celery | |||
| from augur.tasks.init.celery_app import AugurCoreRepoCollectionTask | |||
| from augur.application.db.data_parse import * | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0401: Wildcard import augur.application.db.data_parse (wildcard-import)
| all_data += page_data | ||
|
|
||
| return all_data | ||
| return list(github_data_access.paginate_resource(url)) | ||
|
|
||
| def process_events(events, task_name, repo_id, logger): |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
R0914: Too many local variables (31/30) (too-many-locals)
| all_data += page_data | ||
|
|
||
| return all_data | ||
| return list(github_data_access.paginate_resource(url)) | ||
|
|
||
| def process_events(events, task_name, repo_id, logger): |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
R0915: Too many statements (56/50) (too-many-statements)
| @@ -4,7 +4,7 @@ | |||
| from augur.tasks.init.celery_app import celery_app as celery | |||
| from augur.tasks.init.celery_app import AugurCoreRepoCollectionTask | |||
| from augur.application.db.data_parse import * | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0401: Wildcard import augur.application.db.data_parse (wildcard-import)
Signed-off-by: Andrew Brain <[email protected]>
| @@ -98,7 +98,7 @@ def make_request(self, url, method="GET", timeout=100): | |||
|
|
|||
| with httpx.Client() as client: | |||
|
|
|||
| response = client.request(method=method, url=url, timeout=timeout, follow_redirects=True) | |||
| response = client.request(method=method, url=url, auth=self.key_manager, timeout=timeout, follow_redirects=True) | |||
|
|
|||
| if response.status_code in [403, 429]: | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
R1720: Unnecessary "elif" after "raise", remove the leading "el" from "elif" (no-else-raise)
sgoggins
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Signed commits