Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use key manager in github data access #2838

Merged
merged 2 commits into from
Jun 29, 2024
Merged

Use key manager in github data access #2838

merged 2 commits into from
Jun 29, 2024

Conversation

ABrain7710
Copy link
Contributor

Description

  • The new github data access had a key manager passed to it but it was not using it to make the request, therefore the requests were being made without a github api key. This simply passes the key manager so it is provided an api key

Signed commits

  • Yes, I signed my commits.

@ABrain7710
Make api calls with key
59abdea 
Signed-off-by: Andrew Brain <[email protected]>
sgoggins
sgoggins approved these changes Jun 29, 2024
View reviewed changes
Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix!

@sgoggins sgoggins merged commit 9ba79f0 into dev Jun 29, 2024
9 checks passed
@ABrain7710 ABrain7710 deleted the use-key-manager branch August 7, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@sgoggins sgoggins sgoggins approved these changes

@Ulincsys Ulincsys Awaiting requested review from Ulincsys

@IsaacMilarky IsaacMilarky Awaiting requested review from IsaacMilarky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ABrain7710 @sgoggins