Remove empty files and move redundant folders to simplify project structure #2839

ABrain7710 · 2024-06-29T23:06:54Z

Description

Removed empty core.py files. This left several folders with just a tasks.py for example the issues folder only had a tasks.py. So in the issues example the file was at augur/tasks/github/issues/tasks.py and now it is at augur/tasks/github/issues.py.

Note
Should be merged after: #2840

Signed commits

Yes, I signed my commits.

Signed-off-by: Andrew Brain <[email protected]>

github-actions · 2024-06-29T23:07:30Z

augur/tasks/github/__init__.py

-from augur.tasks.github.events.tasks import *
-from augur.tasks.github.issues.tasks import *
-from augur.tasks.github.messages.tasks import *
+from augur.tasks.github.contributors import *


[pylint] _{reported by reviewdog 🐶}
C0114: Missing module docstring (missing-module-docstring)

github-actions · 2024-06-29T23:07:30Z

augur/tasks/start_tasks.py

@@ -15,7 +15,7 @@
 from augur.tasks.github.pull_requests.files_model.tasks import process_pull_request_files


[pylint] _{reported by reviewdog 🐶}
C0413: Import "from augur.tasks.github.pull_requests.files_model.tasks import process_pull_request_files" should be placed at the top of the module (wrong-import-position)

github-actions · 2024-06-29T23:07:31Z

augur/tasks/start_tasks.py

@@ -15,7 +15,7 @@
 from augur.tasks.github.pull_requests.files_model.tasks import process_pull_request_files
 from augur.tasks.github.pull_requests.commits_model.tasks import process_pull_request_commits


[pylint] _{reported by reviewdog 🐶}
C0413: Import "from augur.tasks.github.pull_requests.commits_model.tasks import process_pull_request_commits" should be placed at the top of the module (wrong-import-position)

github-actions · 2024-06-29T23:07:31Z

augur/tasks/start_tasks.py

@@ -15,7 +15,7 @@
 from augur.tasks.github.pull_requests.files_model.tasks import process_pull_request_files
 from augur.tasks.github.pull_requests.commits_model.tasks import process_pull_request_commits
 from augur.tasks.git.dependency_tasks.tasks import process_ossf_dependency_metrics


[pylint] _{reported by reviewdog 🐶}
C0413: Import "from augur.tasks.git.dependency_tasks.tasks import process_ossf_dependency_metrics" should be placed at the top of the module (wrong-import-position)

github-actions · 2024-06-29T23:07:31Z

augur/tasks/start_tasks.py

@@ -15,7 +15,7 @@
 from augur.tasks.github.pull_requests.files_model.tasks import process_pull_request_files
 from augur.tasks.github.pull_requests.commits_model.tasks import process_pull_request_commits
 from augur.tasks.git.dependency_tasks.tasks import process_ossf_dependency_metrics
-from augur.tasks.github.traffic.tasks import collect_github_repo_clones_data
+from augur.tasks.github.tasks import collect_github_repo_clones_data


[pylint] _{reported by reviewdog 🐶}
C0413: Import "from augur.tasks.github.tasks import collect_github_repo_clones_data" should be placed at the top of the module (wrong-import-position)

github-actions · 2024-06-29T23:07:31Z

augur/tasks/start_tasks.py

@@ -15,7 +15,7 @@
 from augur.tasks.github.pull_requests.files_model.tasks import process_pull_request_files
 from augur.tasks.github.pull_requests.commits_model.tasks import process_pull_request_commits
 from augur.tasks.git.dependency_tasks.tasks import process_ossf_dependency_metrics
-from augur.tasks.github.traffic.tasks import collect_github_repo_clones_data
+from augur.tasks.github.tasks import collect_github_repo_clones_data
 from augur.tasks.gitlab.merge_request_task import collect_gitlab_merge_requests, collect_merge_request_metadata, collect_merge_request_commits, collect_merge_request_files, collect_merge_request_comments


[pylint] _{reported by reviewdog 🐶}
C0413: Import "from augur.tasks.gitlab.merge_request_task import collect_gitlab_merge_requests, collect_merge_request_metadata, collect_merge_request_commits, collect_merge_request_files, collect_merge_request_comments" should be placed at the top of the module (wrong-import-position)

github-actions · 2024-06-29T23:07:31Z

augur/tasks/start_tasks.py

@@ -15,7 +15,7 @@
 from augur.tasks.github.pull_requests.files_model.tasks import process_pull_request_files
 from augur.tasks.github.pull_requests.commits_model.tasks import process_pull_request_commits
 from augur.tasks.git.dependency_tasks.tasks import process_ossf_dependency_metrics
-from augur.tasks.github.traffic.tasks import collect_github_repo_clones_data
+from augur.tasks.github.tasks import collect_github_repo_clones_data
 from augur.tasks.gitlab.merge_request_task import collect_gitlab_merge_requests, collect_merge_request_metadata, collect_merge_request_commits, collect_merge_request_files, collect_merge_request_comments
 from augur.tasks.gitlab.issues_task import collect_gitlab_issues, collect_gitlab_issue_comments


[pylint] _{reported by reviewdog 🐶}
C0413: Import "from augur.tasks.gitlab.issues_task import collect_gitlab_issues, collect_gitlab_issue_comments" should be placed at the top of the module (wrong-import-position)

github-actions · 2024-06-29T23:07:31Z

augur/tasks/start_tasks.py

@@ -15,7 +15,7 @@
 from augur.tasks.github.pull_requests.files_model.tasks import process_pull_request_files
 from augur.tasks.github.pull_requests.commits_model.tasks import process_pull_request_commits
 from augur.tasks.git.dependency_tasks.tasks import process_ossf_dependency_metrics
-from augur.tasks.github.traffic.tasks import collect_github_repo_clones_data
+from augur.tasks.github.tasks import collect_github_repo_clones_data
 from augur.tasks.gitlab.merge_request_task import collect_gitlab_merge_requests, collect_merge_request_metadata, collect_merge_request_commits, collect_merge_request_files, collect_merge_request_comments
 from augur.tasks.gitlab.issues_task import collect_gitlab_issues, collect_gitlab_issue_comments
 from augur.tasks.gitlab.events_task import collect_gitlab_issue_events, collect_gitlab_merge_request_events


[pylint] _{reported by reviewdog 🐶}
C0413: Import "from augur.tasks.gitlab.events_task import collect_gitlab_issue_events, collect_gitlab_merge_request_events" should be placed at the top of the module (wrong-import-position)

Signed-off-by: Andrew Brain <[email protected]>

github-actions · 2024-06-29T23:22:37Z

augur/tasks/start_tasks.py

@@ -15,7 +15,7 @@
 from augur.tasks.github.pull_requests.files_model.tasks import process_pull_request_files
 from augur.tasks.github.pull_requests.commits_model.tasks import process_pull_request_commits
 from augur.tasks.git.dependency_tasks.tasks import process_ossf_dependency_metrics
-from augur.tasks.github.traffic.tasks import collect_github_repo_clones_data
+from augur.tasks.github.traffic import collect_github_repo_clones_data


[pylint] _{reported by reviewdog 🐶}
C0413: Import "from augur.tasks.github.traffic import collect_github_repo_clones_data" should be placed at the top of the module (wrong-import-position)

Signed-off-by: Andrew Brain <[email protected]>

sgoggins

Are you sure? :)

ABrain7710 added 6 commits June 29, 2024 17:53

Remove empty files

ab5b5a0

Signed-off-by: Andrew Brain <[email protected]>

Move contributors tasks out of folder

86c8a68

Signed-off-by: Andrew Brain <[email protected]>

Move events tasks out of folder

3cf11de

Signed-off-by: Andrew Brain <[email protected]>

Move issues tasks out of folder

da49d9e

Signed-off-by: Andrew Brain <[email protected]>

Move messages tasks out of folder

dd4175e

Signed-off-by: Andrew Brain <[email protected]>

Move traffic tasks out of folder

1f7723e

Signed-off-by: Andrew Brain <[email protected]>

github-actions bot reviewed Jun 29, 2024

View reviewed changes

Fix import

bfd6b23

Signed-off-by: Andrew Brain <[email protected]>

github-actions bot reviewed Jun 29, 2024

View reviewed changes

Add missing file

d858c00

Signed-off-by: Andrew Brain <[email protected]>

ABrain7710 marked this pull request as ready for review June 29, 2024 23:27

sgoggins approved these changes Jun 30, 2024

View reviewed changes

sgoggins merged commit 4003fda into dev Jun 30, 2024
9 checks passed

ABrain7710 deleted the remove-empty-files branch August 7, 2024 17:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove empty files and move redundant folders to simplify project structure #2839

Remove empty files and move redundant folders to simplify project structure #2839

ABrain7710 commented Jun 29, 2024 •

edited

Loading

github-actions bot Jun 29, 2024

github-actions bot Jun 29, 2024

github-actions bot Jun 29, 2024

github-actions bot Jun 29, 2024

github-actions bot Jun 29, 2024

github-actions bot Jun 29, 2024

github-actions bot Jun 29, 2024

github-actions bot Jun 29, 2024

github-actions bot Jun 29, 2024

sgoggins left a comment

		@@ -15,7 +15,7 @@
		from augur.tasks.github.pull_requests.files_model.tasks import process_pull_request_files

		@@ -15,7 +15,7 @@
		from augur.tasks.github.pull_requests.files_model.tasks import process_pull_request_files
		from augur.tasks.github.pull_requests.commits_model.tasks import process_pull_request_commits

Remove empty files and move redundant folders to simplify project structure #2839

Remove empty files and move redundant folders to simplify project structure #2839

Conversation

ABrain7710 commented Jun 29, 2024 • edited Loading

github-actions bot Jun 29, 2024

Choose a reason for hiding this comment

github-actions bot Jun 29, 2024

Choose a reason for hiding this comment

github-actions bot Jun 29, 2024

Choose a reason for hiding this comment

github-actions bot Jun 29, 2024

Choose a reason for hiding this comment

github-actions bot Jun 29, 2024

Choose a reason for hiding this comment

github-actions bot Jun 29, 2024

Choose a reason for hiding this comment

github-actions bot Jun 29, 2024

Choose a reason for hiding this comment

github-actions bot Jun 29, 2024

Choose a reason for hiding this comment

github-actions bot Jun 29, 2024

Choose a reason for hiding this comment

sgoggins left a comment

Choose a reason for hiding this comment

ABrain7710 commented Jun 29, 2024 •

edited

Loading