Proper Gunicorn bringup detection #2842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ulincsys <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| logger.info('Gunicorn webserver started...') | ||
| logger.info(f'Augur is running at: {"http" if development else "https"}://{host}:{port}') | ||
| logger.info(f"The API is available at '{api_response.json()['route']}'") | ||
|
|
||
| processes = start_celery_worker_processes(float(worker_vmem_cap), disable_collection) |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0621: Redefining name 'processes' from outer scope (line 383) (redefined-outer-name)
| @@ -91,7 +108,6 @@ def start(ctx, disable_collection, development, port): | |||
| celery_beat_process = subprocess.Popen(celery_command.split(" ")) | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
Signed-off-by: Ulincsys <[email protected]>
| logger.info('Gunicorn webserver started...') | ||
| logger.info(f'Augur is running at: {"http" if development else "https"}://{host}:{port}') | ||
| logger.info(f"The API is available at '{api_response.json()['route']}'") | ||
|
|
||
| processes = start_celery_worker_processes(float(worker_vmem_cap), disable_collection) |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0621: Redefining name 'processes' from outer scope (line 386) (redefined-outer-name)
sgoggins
approved these changes
Jul 2, 2024
ABrain7710
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/apiroute to get the location of the backend APIbackend startinvocation/apito check that service has startedFuture Work
Signed commits