Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add empty output handle #2855

Merged
merged 5 commits into from
Jul 1, 2024
Merged

add empty output handle #2855

merged 5 commits into from
Jul 1, 2024

Conversation

IsaacMilarky
Copy link
Contributor

Description

  • Handle if stdout is empty when parsing it into JSON

Signed commits

  • Yes, I signed my commits.

@@ -142,8 +142,6 @@ def non_repo_domain_tasks(self):

enabled_tasks = []

enabled_tasks.extend(generate_non_repo_domain_facade_tasks(logger))

if not RUNNING_DOCKER and machine_learning_phase.__name__ in enabled_phase_names:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
E0601: Using variable 'machine_learning_phase' before assignment (used-before-assignment)

@@ -142,8 +142,6 @@ def non_repo_domain_tasks(self):

enabled_tasks = []

enabled_tasks.extend(generate_non_repo_domain_facade_tasks(logger))

if not RUNNING_DOCKER and machine_learning_phase.__name__ in enabled_phase_names:
#enabled_tasks.extend(machine_learning_phase())
from augur.tasks.data_analysis.contributor_breadth_worker.contributor_breadth_worker import contributor_breadth_model
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
C0415: Import outside toplevel (augur.tasks.data_analysis.contributor_breadth_worker.contributor_breadth_worker.contributor_breadth_model) (import-outside-toplevel)

Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sgoggins sgoggins merged commit c1b7a84 into dev Jul 1, 2024
8 of 9 checks passed
@ABrain7710 ABrain7710 deleted the add-json-parse-handle branch August 7, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants