Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor github graphql #2861

Merged
merged 15 commits into from
Jul 16, 2024
Merged

Refactor github graphql #2861

merged 15 commits into from
Jul 16, 2024

Conversation

ABrain7710
Copy link
Contributor

Description

  • Create graphql equivalent to the new github data access so we can be sure that the proper exception will be thrown when an error occurs.
  • This change is in response to these TimeoutError: No data received from endpoint. errors in the current logic. These occur when we don't get data (None is returned) due to us returning None in places rather than throwing exceptions. The new code will help us understand why the error is occurring because it will throw an exception for any issue rather than returning None.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
@ABrain7710 ABrain7710 marked this pull request as ready for review July 15, 2024 23:48
Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sgoggins sgoggins merged commit 1cfcd38 into dev Jul 16, 2024
9 checks passed
@ABrain7710 ABrain7710 deleted the graphql_refactor branch August 7, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants