GitHub data access pr migration #2864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
Signed-off-by: Andrew Brain <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -50,18 +49,18 @@ def collect_pull_requests(repo_git: str, full_collection: bool) -> int: | |||
| all_data.append(pr) | |||
|
|
|||
| if len(all_data) >= 1000: | |||
| process_pull_requests(all_data, f"{owner}/{repo}: Pr task", repo_id, logger, augur_db) | |||
| process_pull_requests(all_data, f"{owner}/{repo}: Github Pr task", repo_id, logger, augur_db) | |||
| total_count += len(all_data) | |||
| all_data.clear() | |||
|
|
|||
| if len(all_data): | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C1802: Do not use len(SEQUENCE) without comparison to determine if a sequence is empty (use-implicit-booleaness-not-len)
| total_count += len(all_data) | ||
| all_data.clear() | ||
|
|
||
| if len(all_data): | ||
| process_pull_requests(all_data, f"{owner}/{repo}: Pr task", repo_id, logger, augur_db) | ||
| process_pull_requests(all_data, f"{owner}/{repo}: Github Pr task", repo_id, logger, augur_db) | ||
| total_count += len(all_data) | ||
|
|
||
| if total_count > 0: |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return)
| @@ -278,8 +263,7 @@ def collect_pull_request_review_comments(repo_git: str) -> None: | |||
| pr_review_msg_mapping_data = {} | |||
|
|
|||
| pr_review_comments_len = len(all_raw_pr_review_messages) | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0612: Unused variable 'pr_review_comments_len' (unused-variable)
IsaacMilarky
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed commits