Add Step to Fetch Missing Git Messages from Commits Analyzed Before Commits Message Table was Added #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Isaac Milarsky <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| try: | ||
| missing_commit_hashes = fetchall_data_from_sql_text(fetch_missing_hashes_sql) | ||
| except: |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0702: No exception type(s) specified (bare-except)
Signed-off-by: Isaac Milarsky <[email protected]>
Signed-off-by: Isaac Milarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now the commits that were analyzed before the commit message table was added to the database don't have any commit message and they won't get collected because Augur considers those commits already collected and won't collect them again unless a recollection is triggered in facade for some reason.
The solution to this is to go back and fetch them after we analyze commits.
Signed commits