Adjust error message format in multi-locale library codegen to be more useful #13393
Conversation
|
I'm assuming you've run test/interop/C/multilocale and test/interop/python/multilocale on OSx with this change? |
|
I haven't. There's a bit of a chicken and the egg problem here. I updated the error messages in the compiler (this PR) so I could figure out why the tests were breaking (#13394). If you'd like, I can merge that fix first and then pull it into this branch. |
|
You could always check out a version of master from before the change and see what this change does on that branch, just as a sanity check. |
|
That sounds like a good idea, thanks! |
|
I'd otherwise be in favor of merging this so it doesn't stay open, but recognizing that if there are failures because of it, they'll be spread across this branch and the fix branch. |
|
Alternatively, why don't I just close this PR and integrate these changes into the fix branch? |
|
Either way works |
|
Closed in favor of #13403. |
…pe-errors Skip standard modules when generating MLL wrappers This PR will resolve #13394. Standard modules export functions with types that multi-locale libraries are not ready to support yet. This PR causes the code generation for exported functions in multi-locale libraries to skip over standard modules as well as internal. In addition, this PR also absorbs changes from closed PR #13393, since that PR's testing was dependent on this. Testing: - [x] interop/C/multilocale on darwin when CHPL_COMM=gasnet - [x] interop/python/multilocale on darwin when CHPL_COMM=gasnet - [x] ALL on linux64 when CHPL_COMM=gasnet - [x] ALL on linux64 when CHPL_COMM=none Thanks @lydia-duncan for review.
This is a small PR that adjusts the format of error messages in multi-locale library codegen so that they provide more useful information.
Currently, multi-locale libraries fail to compile due to an unsupported type. After implementing this quick adjustment, the new error message reveals...
Testing:
interop/C/multilocaleondarwinwhenCHPL_COMM=gasnetinterop/python/multilocaleondarwinwhenCHPL_COMM=gasnet