Code

simplify use/import shadowing#19306

Code

Merged

mppf merged 96 commits intochapel-lang:mainchapel-lang/chapel:mainfrom mppf:use-shadow-scopesmppf/chapel:use-shadow-scopesCopy head branch name to clipboardMay 10, 2022

+2,829-2,125

Commits

Commits on May 10, 2022

• Ambiguity error for module defining sym with same name

  Show description for bb26de1
  mppf

  committed
  bb26de1

• Only private use has shadow scope

  Show description for 60e8b73
  mppf

  committed
  60e8b73

• Move new tests to modules/shadowing

  Show description for be01731
  mppf

  committed
  be01731

• Make isMoreVisible in disambiguation consistent

  Show description for 095a898
  mppf

  committed
  095a898

• Partial work

  Show description for 4aa6966
  mppf

  committed
  4aa6966

• Tidy up new tests

  Show description for dc9d125
  mppf

  committed
  dc9d125

• Fix test issue-19167-3-x

  Show description for e907b2d
  mppf

  committed
  e907b2d

• Adjust modules primer

  Show description for 8f853a0
  mppf

  committed
  8f853a0

• Allow private use to have 2 shadow scopes

  Show description for cc7d1f9
  mppf

  committed
  cc7d1f9

• Fix test_resolve_best_shadowed2 for different shadowing

  Show description for 291d2ce
  mppf

  committed
  291d2ce

• Fix apparently inadverdent use of Random

  Show description for c604074
  mppf

  committed
  c604074

• Use the POI scope to start isMoreVisible

  Show description for 8c994d9
  mppf

  committed
  8c994d9

• Add test from issue chapel-lang#19198

  Show description for 37d9a23
  mppf

  committed
  37d9a23

• Update some module scoping tests

  Show description for 551d0fa
  mppf

  committed
  551d0fa

• Use private use rather than public use

  Show description for f942a9a
  mppf

  committed
  f942a9a

• Use 'pe' rather than 'e' to avoid conflicts with Math.e

  Show description for 8a60461
  mppf

  committed
  8a60461

• Rename module with same name as class

  Show description for d8e3e35
  mppf

  committed
  d8e3e35

• Update a spec test for new behavior

  Show description for f06629a
  mppf

  committed
  f06629a

• Avoid conflict with Math.e by moving use

  Show description for 39127a3
  mppf

  committed
  39127a3

• Update test for back to 2 shadow scopes for private use

  Show description for cc1afb3
  mppf

  committed
  cc1afb3

• Update breakList.good for new behavior

  Show description for 8c774b8
  mppf

  committed
  8c774b8

• Fix except handling

  Show description for f628a0e
  mppf

  committed
  f628a0e

• Check in nested public imports & track publicOnly

  Show description for 6b990c1
  mppf

  committed
  6b990c1

• Use ee instead of e to avoid Math.e

  Show description for 4c3278e
  mppf

  committed
  4c3278e

• Adjust anotherMultipleDef and add a variant

  Show description for 4a8ddfe
  mppf

  committed
  4a8ddfe

• update tests for ambiguity due to no shadow import

  Show description for b1dbbb2
  mppf

  committed
  b1dbbb2

• Adjust for no shadow public use

  Show description for 30e30d4
  mppf

  committed
  30e30d4

• Fix rename + recursion check

  Show description for c6287ac
  mppf

  committed
  c6287ac

• Fix private module check

  Show description for 60b2e84
  mppf

  committed
  60b2e84

• Fix TestSorted future

  Show description for 5ab2235
  mppf

  committed
  5ab2235

• Adjust a future's .good file

  Show description for 6e73790
  mppf

  committed
  6e73790

• Use qualified naming to avoid std module Types

  Show description for d1b8236
  mppf

  committed
  d1b8236

• Adjust tests to avoid chapel-lang#19303

  Show description for e04ae58
  mppf

  committed
  e04ae58

• Change deepUseWouldConflict.good file instead of test

  Show description for cb1baa6
  mppf

  committed
  cb1baa6

• Update weirdEnumHiding to show private use

  Show description for 6703dbf
  mppf

  committed
  6703dbf

• Keep public use but rename checkFoo functions

  Show description for 5f47311
  mppf

  committed
  5f47311

• Add variant that calls mCallFunc

  Show description for 8ea910e
  mppf

  committed
  8ea910e

• Give the two x variables different values

  Show description for 495dec3
  mppf

  committed
  495dec3

• Continue with module counts / class count but don't public use

  Show description for bb87175
  mppf

  committed
  bb87175

• Adjust which is code clone to preserve history

  Show description for 327b59f
  mppf

  committed
  327b59f

• Public use doesn't bring in module name

  Show description for 9023947
  mppf

  committed
  9023947

• Add import Path to MasonPublish.

  Show description for 7c60985
  mppf

  committed
  7c60985

• Un-future now passing future

  Show description for 5f71c59
  mppf

  committed
  5f71c59

• Allow 'public use Foo as F' to bring in F

  Show description for ed89198
  mppf

  committed
  ed89198

• Add variant of test to do 'public use Foo as Foo'

  Show description for 498c460
  mppf

  committed
  498c460

• Update importAndImportFromUse.good and add clone

  Show description for a237c58
  mppf

  committed
  a237c58

• Adjust multipleUnqualified

  Show description for bdd5287
  mppf

  committed
  bdd5287

• Adjust tests in visibility/import to have public use

  Show description for fdff165
  mppf

  committed
  fdff165

• Use 'use A as A' in this directory to keep tests as they were

  Show description for 5915aba
  mppf

  committed
  5915aba

• Revert "Adjust tests in visibility/import to have public use"

  Show description for 78ab7a4
  mppf

  committed
  78ab7a4

• Update .good files with errors

  Show description for 38f5ca6
  mppf

  committed
  38f5ca6

• Adjust onlyNothingField.chpl

  Show description for b5d224a
  mppf

  committed
  b5d224a

• Import FFTW in addition to public using it

  Show description for 3de539d
  mppf

  committed
  3de539d

• Adjust ChapelStandard to public use X as X

  Show description for 92c37e8
  mppf

  committed
  92c37e8

• Add test cases from issue chapel-lang#19352

  Show description for 3297bf1
  mppf

  committed
  3297bf1

• Try having methods never shadow in fn disambiguation

  Show description for bc6808d
  mppf

  committed
  bc6808d

• Remove redundant proc rank from DimensionalArr

  Show description for 6602699
  mppf

  committed
  6602699

• Put breakList.good back

  Show description for a37bce4
  mppf

  committed
  a37bce4

• Update .good for ambiguity

  Show description for 07f7b12
  mppf

  committed
  07f7b12

• Update Application8.good to be ambiguity

  Show description for f5c7b18
  mppf

  committed
  f5c7b18

• Split check-gc-reuse-funmets into test of fns and methods

  Show description for 8bf282e
  mppf

  committed
  8bf282e

• Avoid ambiguity for local method

  Show description for 934865f
  mppf

  committed
  934865f

• Use non-method operator in inlineKeyword

  Show description for 6f88b4a
  mppf

  committed
  6f88b4a

• overload set checking uses isMoreVisible on methods

  Show description for d55bb2c
  mppf

  committed
  d55bb2c

• Add != on chpl_taskID_t

  Show description for 62c74ac
  mppf

  committed
  62c74ac

• Remove local chpl_taskID_t operators

  Show description for 41020fb
  mppf

  committed
  41020fb

• Use non-operator method to avoid ambiguity

  Show description for d919281
  mppf

  committed
  d919281

• Use non-method operator to avoid ambiguity

  Show description for 4d34506
  mppf

  committed
  4d34506

• Update .good files for public use A not bringing in A

  Show description for cd1c1cb
  mppf

  committed
  cd1c1cb

• Add warning for 'public use M only;'

  Show description for a8b987f
  mppf

  committed
  a8b987f

• Fix noAssignClass to error even if candidate not chosen

  Show description for d190dbf
  mppf

  committed
  d190dbf

• Don't warn for public use M only X as Y

  Show description for d9c8469
  mppf

  committed
  d9c8469

• Update useOnlyNothing tests

  Show description for d58b03e
  mppf

  committed
  d58b03e

• Improve a comment

  Show description for a908f6d
  mppf

  committed
  a908f6d

• Delete an out-of-date comment

  Show description for 013a388
  mppf

  committed
  013a388

• Change breakList.good to "I got you"

  Show description for f7b8898
  mppf

  committed
  f7b8898

• Improve Can't overload = error for ptr types

  Show description for 0195a19
  mppf

  committed
  0195a19

• Included expected Can't override = error

  Show description for 5b3b6a7
  mppf

  committed
  5b3b6a7

• Move check for unsupported assignment overload

  Show description for e648c66
  mppf

  committed
  e648c66

• Exit loop early when possible (based on review feedback)

  Show description for 268cad7
  mppf

  committed
  268cad7

• Updated modules section

  Show description for cdb34d6
  mppf

  committed
  cdb34d6

• Remove comment since I can't think of a counterexample

  Show description for 7469d61
  mppf

  committed
  7469d61

• Update module primers

  Show description for 6b12aba
  mppf

  committed
  6b12aba

• Revert "Move check for unsupported assignment overload"

  Show description for 3d5a20a
  mppf

  committed
  3d5a20a

• Revert "Included expected Can't override = error"

  Show description for 184e7f0
  mppf

  committed
  184e7f0

• Revert "Improve Can't overload = error for ptr types"

  Show description for d4c63dc
  mppf

  committed
  d4c63dc

• Allow error for overloading assignment for c_string

  Show description for ffc6988
  mppf

  committed
  ffc6988

• Accept change in output for foo2 test for now

  Show description for 2b26e85
  mppf

  committed
  2b26e85

• Improve function argument shadowing error

  Show description for c656bb0
  mppf

  committed
  c656bb0

• Include another example in modules primer

  Show description for 80e8296
  mppf

  committed
  80e8296

• Revert "Fix noAssignClass to error even if candidate not chosen"

  Show description for b30c0fd
  mppf

  committed
  b30c0fd

• Accept fewer errors in noAssignClass

  Show description for c126dd1
  mppf

  committed
  c126dd1

• Add param to enable this/local this, use in autoLocalAccess tests

  Show description for 54cfad7
  mppf

  committed
  54cfad7

• Address Lydia's feedback

  Show description for 393e94b
  mppf

  committed
  393e94b

• Revert "Allow error for overloading assignment for c_string"

  Show description for 4e73421
  mppf

  committed
  4e73421

• Fix up comments in new tests

  Show description for 5403f88
  mppf

  committed
  5403f88