Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler cleanups #21684

Merged
merged 8 commits into from
Feb 25, 2023
Merged

Compiler cleanups #21684

merged 8 commits into from
Feb 25, 2023

Conversation

mppf
Copy link
Member

@mppf mppf commented Feb 24, 2023

This PR takes the following cleanup steps:

  • moves frontend/lib/framework/(parser-error-classes-list.cpp,resolution-error-classes-list.cpp} to the frontend/lib/parsing and frontend/lib/resolution directories, and similarly moves the headers
  • moves UnsupportedAsIdent to parser errors list since it is emitted by post-parse-checks
  • fix extra space in some error messages and avoids an unhelpful "In module" output for one error message (follow-up to PR improve dyno scope resolve errors with lookup tracing #21637)
  • updates a number of loops like for (auto elt : something()) to use for (const auto& elt : something()) in cases where the element type is bigger than a pointer. The version without the & will cause a copy of the element on each iteration.

Reviewed by @DanilaFe - thanks!

  • full local testing
  • no new --dyno failures

mppf added 5 commits February 24, 2023 08:42
For

   test/functions/iterators/recursive/recursive-iter-findfilesfailure.chpl

---
Signed-off-by: Michael Ferguson <[email protected]>
For
   test/visibility/rename/renameUsedMod/renameModRenameSymBadAccess2.chpl

---
Signed-off-by: Michael Ferguson <[email protected]>
@mppf mppf changed the title Misc dyno cleanups Compiler cleanups Feb 24, 2023
mppf added 3 commits February 24, 2023 12:27
---
Signed-off-by: Michael Ferguson <[email protected]>
---
Signed-off-by: Michael Ferguson <[email protected]>
@mppf mppf merged commit e38491a into chapel-lang:main Feb 25, 2023
@mppf mppf deleted the follow-21637 branch February 25, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants