Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hostname match and more tests #79

Merged
merged 3 commits into from
Jun 13, 2022
Merged

fix: hostname match and more tests #79

merged 3 commits into from
Jun 13, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Jun 9, 2022 •
edited
Loading

  • test both example configs to make sure they are in fact valid
  • found a bug in the ssh config parser: it was only matching against the Host, while it should in fact also parse against HostName when it is not empty - fixed and the example config is the test for it

depends on #78

@caarlos0 caarlos0 added the bug Something isn't working label Jun 9, 2022
@caarlos0 caarlos0 self-assigned this Jun 9, 2022
@caarlos0 caarlos0 marked this pull request as draft June 9, 2022 18:03
@caarlos0 caarlos0 marked this pull request as ready for review June 11, 2022 02:29
@caarlos0 caarlos0 merged commit f6fc86e into main Jun 13, 2022
@caarlos0 caarlos0 deleted the includes branch June 13, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@caarlos0 caarlos0

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@caarlos0