Testsuite bugfix: ubuntu 24.04 drops python 3.7 #286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayantaylor
requested review from
matthiasdiener,
ericjbohm,
adityapb,
ritvikrao and
ZwFink
|
The documentation should also be changed to reflect the changes. |
|
Re: documentation updates. I'll make a separate PR dropping 3.7 with relevant doc updates. This PR shouldn't require any documentation change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test ci uses "ubuntu-latest" which was recently bumped from 22.04 to 24.04. Ubuntu24.04 no longer supports Python3.7. This PR aims to fix the CI test failure. More details on ubuntu/python support listed here.
Noting that python3.7 hit EOL in 2023, it may be time to just remove python3.7 support instead of making fixes like this. Thoughts?