-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when including both stellar-hd-wallet and stellar-sdk in my project #10
Comments
Related to stellar/js-stellar-sdk#191 |
i'm not sure what's going on here. the "TS errors", is that typescript executing the code? or tsc compiling? |
This just happens when requiring them. I realized it's not actually TypeScript errors. |
I'm getting the same with webpack/babel. The solution was to upgrade |
ok great. thanks @johansten. i'll do a release with this fix now. |
released 0.0.7 to npm which includes this fix. |
I should add that I had to include |
Fix ready in stellar/js-xdr#21. |
This is fixed in: |
awesome. thanks @bartekn, i will deploy a new version with the new stellar-base version, |
When I include both
stellar-hd-wallet
andstellar-sdk
in my project I get errors when requiring them both asstellar-base
is included twice, not sure ifstellar-base
should instead be apeerDependency
or how to solve this...Any suggestions?
These are the related deps in my package.json:
The text was updated successfully, but these errors were encountered: