Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update memory limit #79

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Conversation

dkwon17
Copy link
Collaborator

@dkwon17 dkwon17 commented Jun 22, 2022

Signed-off-by: David Kwon [email protected]

This PR increases the memory limit to match the memory limit for the che-operator deployment: https://github.com/eclipse-che/che-operator/blob/3830ac4e28983dbe928d0777f63c87bed43feb4b/deploy/deployment/openshift/objects/che-operator.Deployment.yaml#L132

After discussing with @ibuziuk , we plan to do a KIPO 1.0.1 release with this change.

Fixes: eclipse-che/che#21448

Signed-off-by: David Kwon <[email protected]>
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@dkwon17 dkwon17 requested a review from tolusha June 22, 2022 16:34
Copy link
Collaborator

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @dkwon17 could you please clarify if the PR was tested it on a cluster with ~ 300 namespaces?

@dkwon17
Copy link
Collaborator Author

dkwon17 commented Jun 22, 2022

I was able to verify that the PR increases the KIPO pod's memory limit, but I wasn't able to reproduce the original problem on my test cluster even with 300+ namespaces, as the memory usage never exceeds 128mib in my case:
image

image

The namespaces were created by running oc new-project <namespace-name> 300 times

@dkwon17
Copy link
Collaborator Author

dkwon17 commented Jun 22, 2022

This is the bundle-image for this PR: quay.io/dkwon17/kubernetes-image-puller-operator-bundle:next, maybe we could try it on the che-dev cluster by running the following? I don't have access to the openshift-operators namespace to test it myself

 operator-sdk run bundle quay.io/dkwon17/kubernetes-image-puller-operator-bundle:next --namespace openshift-operators

@tolusha
Copy link
Collaborator

tolusha commented Jun 23, 2022

It is ok as workaround but we need to consider a robust solution.
Either use non caching client or limit cache by some label selector.

@ibuziuk ibuziuk merged commit 4a7a2fd into che-incubator:main Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubernetes-image-puller-operator 1.0.0 is in the CrashLoopBackOff State due to low memory limits
3 participants