Skip to content
This repository has been archived by the owner on Jan 18, 2025. It is now read-only.

feat: add print console #37

Merged
merged 3 commits into from
Jan 15, 2025
Merged

feat: add print console #37

merged 3 commits into from
Jan 15, 2025

Conversation

NTGNguyen
Copy link
Collaborator

@KevinNitroG please check this branch before merging

@NTGNguyen NTGNguyen requested a review from KevinNitroG January 14, 2025 06:31
@KevinNitroG KevinNitroG added the enhancement New feature or request label Jan 14, 2025
@KevinNitroG KevinNitroG added this to the stable release milestone Jan 14, 2025
@@ -27,18 +27,9 @@ def __eq__(self, other: Any):
return self.plate == other.plate
return False

def __str__(self):
# TODO: Handle show details later when main updates that option
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handle show details later when main updates that option

@KevinNitroG KevinNitroG marked this pull request as draft January 14, 2025 17:33
@@ -27,54 +27,49 @@ def __eq__(self, other: Any):
return self.plate == other.plate
return False

def __str__(self):
# TODO: Handle show details later when main updates that option
def __str__(self) -> str:
def create_violation_str(violation: ViolationDetail, index: int) -> str:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create str method in violation model instead in this big class

@NTGNguyen NTGNguyen marked this pull request as ready for review January 15, 2025 05:35
@NTGNguyen NTGNguyen merged commit 02551e2 into main Jan 15, 2025
4 checks passed
@KevinNitroG KevinNitroG deleted the feat/print-console branch January 15, 2025 16:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants