Skip to content
This repository has been archived by the owner on Jan 18, 2025. It is now read-only.

feat: get data from phatnguoi.vn #38

Merged
merged 11 commits into from
Jan 15, 2025
Merged

feat: get data from phatnguoi.vn #38

merged 11 commits into from
Jan 15, 2025

Conversation

NTGNguyen
Copy link
Collaborator

implement #36

@NTGNguyen NTGNguyen self-assigned this Jan 14, 2025
@KevinNitroG KevinNitroG added this to the stable release milestone Jan 14, 2025
@KevinNitroG KevinNitroG linked an issue Jan 14, 2025 that may be closed by this pull request
add phatnguoi.vn api #36
Closed
@NTGNguyen NTGNguyen requested a review from KevinNitroG January 14, 2025 10:25
KevinNitroG
KevinNitroG suggested changes Jan 14, 2025
View reviewed changes
Copy link
Member

@KevinNitroG KevinNitroG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will review in detail later.

KevinNitroG
KevinNitroG suggested changes Jan 14, 2025
View reviewed changes
Copy link
Member

@KevinNitroG KevinNitroG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bruh bruh

src/check_phat_nguoi/get_data/engines/phat_nguoi.py Outdated Show resolved Hide resolved
@KevinNitroG KevinNitroG merged commit c441a50 into main Jan 15, 2025
3 of 4 checks passed
@KevinNitroG KevinNitroG deleted the feat/phatnguoi-api branch January 15, 2025 16:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KevinNitroG KevinNitroG KevinNitroG approved these changes

Assignees

@NTGNguyen NTGNguyen

Labels
None yet
Projects
None yet
Milestone
stable release
Development

Successfully merging this pull request may close these issues.

add phatnguoi.vn api
2 participants
@NTGNguyen @KevinNitroG