Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<chef-markdown> stencile component gives errors in browser console #3462

Closed
sachin-msys opened this issue Apr 22, 2020 · 0 comments · Fixed by #3473
Closed

<chef-markdown> stencile component gives errors in browser console #3462

sachin-msys opened this issue Apr 22, 2020 · 0 comments · Fixed by #3473
Labels
automate-infra-proxy automate-ui bug 🐛 Something isn't working ui

Comments

@sachin-msys
Copy link
Contributor

Describe the bug

I have used chef-markdown component to show cookbook detail README file which gives console errors

To Reproduce

Steps to reproduce the behavior:

  1. git fetch origin Sachin/infra-cookbook-details
  2. build components/automate-ui
  3. Go to Chef Servers option which is under Infrastructure tab and its under Chef-Server feature flag.
  4. Add chef server and organisation credentials.
  5. After doing all the above steps flow would be Chef Server >> Chef Organisation Details >> Any Cookbook Details
  6. Now you can observe the error in browser console

Expected behavior

Should not be any errors in browser console.

Screenshots

chef-markdown-error

Versions (please complete the following information):

  • OS: Ubuntu 18
  • Browser chrome latest
scottopherson pushed a commit that referenced this issue Apr 23, 2020
Handle languages unrecognized by chef-snippet
52be188 
`chef-snippet` will throw an error if the syntax grammar rules for the language are unavailable.

Instead, this commit modifies the code highlighter to fallback to rendering code blocks as uncolored plain text in this scenario.
PrismJS/prism#344 (comment)

Fixes #3462

Signed-off-by: Scott Christopherson <[email protected]>
@scottopherson scottopherson mentioned this issue Apr 23, 2020
Merged
4 tasks
scottopherson pushed a commit that referenced this issue Apr 23, 2020
Handle languages unrecognized by chef-snippet
16f443e 
`chef-snippet` will throw an error if the syntax grammar rules for the language are unavailable.

Instead, this commit modifies the code highlighter to fallback to rendering code blocks as uncolored plain text in this scenario.
PrismJS/prism#344 (comment)

Fixes #3462

Signed-off-by: Scott Christopherson <[email protected]>
susanev pushed a commit that referenced this issue Apr 24, 2020
@scottopherson
Handle languages unrecognized by chef-snippet (#3473)
2b1b67a 
`chef-snippet` will throw an error if the syntax grammar rules for the language are unavailable.

Instead, this commit modifies the code highlighter to fallback to rendering code blocks as uncolored plain text in this scenario.
PrismJS/prism#344 (comment)

Fixes #3462

Signed-off-by: Scott Christopherson <[email protected]>
@sachin-msys sachin-msys mentioned this issue Apr 24, 2020
Merged
2 tasks
This was referenced Nov 28, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
automate-infra-proxy automate-ui bug 🐛 Something isn't working ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle languages unrecognized by chef-snippet chef/automate
1 participant
@sachin-msys