Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final: Remove PG password in plain text - cs components #8776

Open
wants to merge 22 commits into
base: CHEF-5668
Choose a base branch
from
Open

Final: Remove PG password in plain text - cs components #8776

wants to merge 22 commits into from

Conversation

jashaik
Copy link
Contributor

@jashaik jashaik commented Feb 6, 2025

🔩 Description: What code changed, and why?

⛓️ Related Resources

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

SanjuPal01 and others added 19 commits December 31, 2024 21:13
@SanjuPal01 @jashaik
Sanju/remove pg password from a2 platform file (#8674)
6d9b77f 
* Storing password in secret helper

Signed-off-by: “SanjuPal01” <[email protected]>

* Adding Dex Component Changes

Signed-off-by: “SanjuPal01” <[email protected]>

* Reading password from secret helper in notification-service

Signed-off-by: “SanjuPal01” <[email protected]>

---------

Signed-off-by: “SanjuPal01” <[email protected]>
@jashaik
Updated cs components to access pg password from secrets
2d837ef 
Signed-off-by: jan shahid shaik <[email protected]>
@jashaik
Fix for standalone automate setup in cs components
22c85dc 
Signed-off-by: jan shahid shaik <[email protected]>
@jashaik
Added super user for cs components
76929fa 
Signed-off-by: jan shahid shaik <[email protected]>
@jashaik
Fix
c83d179 
Signed-off-by: jan shahid shaik <[email protected]>
@jashaik
Made pg secret as optional
e6d11c7 
Signed-off-by: jan shahid shaik <[email protected]>
@jashaik
some fix
ea533d3 
Signed-off-by: jan shahid shaik <[email protected]>
@jashaik
some
a31d08f 
Signed-off-by: jan shahid shaik <[email protected]>
@jashaik
Dump logs
ac07687 
Signed-off-by: jan shahid shaik <[email protected]>
@jashaik
Certs export
edeca4e 
Signed-off-by: jan shahid shaik <[email protected]>
@jashaik
certs
2cab947 
Signed-off-by: jan shahid shaik <[email protected]>
@jashaik
reverted cert changes
588b928 
Signed-off-by: jan shahid shaik <[email protected]>
@jashaik
cert changes
a8b38fb 
Signed-off-by: jan shahid shaik <[email protected]>
@jashaik
more logs
29a506a 
Signed-off-by: jan shahid shaik <[email protected]>
@jashaik
some
2a5deb4 
Signed-off-by: jan shahid shaik <[email protected]>
@jashaik
some
3b5f1dd 
Signed-off-by: jan shahid shaik <[email protected]>
@jashaik
TLS verify_ca verify mode
71b5dba 
Signed-off-by: jan shahid shaik <[email protected]>
@jashaik
removed debug logs from ha_chef_server
d257aa5 
Signed-off-by: jan shahid shaik <[email protected]>
@jashaik
Final changes with erchef fix
1a58dc7 
Signed-off-by: jan shahid shaik <[email protected]>
@netlify Netlify
Copy link

netlify bot commented Feb 6, 2025 •
edited
Loading

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit 58aee00
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/67ab41730ef3f60008e47ad8

jashaik and others added 2 commits February 7, 2025 13:05
@jashaik jashaik changed the base branch from main to CHEF-5686 February 11, 2025 12:26
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 11, 2025
View reviewed changes
...omate-backend-elasticsidecar/cmd/automate-backend-elasticsidecar/commands/elastic_sidecar.go Outdated
func (es *ElasticSidecar) testAuthentication(user, pass string) (int, string) {
client := &http.Client{
Transport: &http.Transport{
TLSClientConfig: &tls.Config{InsecureSkipVerify: true}, // nosemgrep

Check failure

Code scanning / CodeQL

Disabled TLS certificate check High

InsecureSkipVerify should not be used in production code.
@jashaik
Standalon fix
52694ac 
Signed-off-by: jan shahid shaik <[email protected]>
@jashaik jashaik changed the base branch from CHEF-5686 to CHEF-5668 February 11, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jashaik @SanjuPal01 @RoyShravani