Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed development mode not work under old react-hot-loader #514

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed development mode not work under old react-hot-loader #514

wants to merge 1 commit into from

Conversation

ryuever
Copy link

@ryuever ryuever commented Jan 6, 2018 •
edited
Loading

For current master version, run npm run start will exit with following error message.

...
ERROR in ./demos/demo1-chat-heads/index.jsx
Module not found: Error: Cannot resolve module 'react/lib/ReactMount' in /xxx/react-motion/demos/demo1-chat-heads
 @ ./demos/demo1-chat-heads/index.jsx 1:379-410

ERROR in ./demos/demo1-chat-heads/Demo.jsx
Module not found: Error: Cannot resolve module 'react/lib/ReactMount' in /xxx/react-motion/demos/demo1-chat-heads
 @ ./demos/demo1-chat-heads/Demo.jsx 1:379-410

ERROR in ./demos/demo5-spring-parameters-chooser/index.jsx
Module not found: Error: Cannot resolve module 'react/lib/ReactMount' in /xxx/react-motion/demos/demo5-spring-parameters-chooser
 @ ./demos/demo5-spring-parameters-chooser/index.jsx 1:379-410
...

and, according to 417, react-hot-loader 1.x doesn't support any more. So I have make the update for latest react-hot-loader version.

@ByronHsu ByronHsu mentioned this pull request Feb 18, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ryuever