Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Migrate static analysis away from phan #277

Closed
codemasher opened this issue Jul 15, 2024 · 0 comments
Closed

[ENHANCEMENT] Migrate static analysis away from phan #277

codemasher opened this issue Jul 15, 2024 · 0 comments

Comments

@codemasher
Copy link
Member

codemasher commented Jul 15, 2024

Describe the feature

This (and all other chillerlan libraries) use phan/phan as static analysis tool.
The problem is, that both, the phan library as well as its required extension php-ast seem unmaintained for several months now (or even abandoned). On top of that, several of phan's dependencies emit deprecation notices in PHP 8.4, so this migration is crucial for PHP 8.4+.

The 2 popular options here are phpstan and psalm. I don't have an opinion yet, but I'd prefer the one that gives me the least of a headache.

Update: It has been decided on phpstan.
Update2: It seems that phan isn't entirely dead - let's see how it develops. Would be great to have it alongside as it's the only static analyzer that properly takes care of imports.

Are you (the requester) willing to submit a pull request for that feature?

[YES] (I guess!?)

codemasher added a commit to chillerlan/php-authenticator that referenced this issue Jul 16, 2024
codemasher added a commit to chillerlan/php-authenticator that referenced this issue Jul 16, 2024
codemasher added a commit to chillerlan/php-authenticator that referenced this issue Jul 17, 2024
codemasher added a commit to chillerlan/php-library-template that referenced this issue Jul 17, 2024
codemasher added a commit to chillerlan/php-library-template-nodocs that referenced this issue Jul 17, 2024
codemasher added a commit that referenced this issue Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant