-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
user/zrepl-dsh2dsh: new package #3137
base: master
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,24 @@ | |||
pkgname = "zrepl-dsh2dsh" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just call it zrepl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no problem renaming it. But this is a fork and may be confusing for someone expecting the original zrepl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unless there is something in original zrepl that makes it worth preferring over the fork and thus warrants having a separate package for it that would conflict, this should be just zrepl
build_style = "go" | ||
hostmakedepends = ["go"] | ||
depends = ["zfs"] | ||
provides = [self.with_pkgver("zrepl")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drop this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corresponds with the comment above. I may actually provide template for both zrepl and this new fork. Than this would be needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this fork more useful from many points of view. And the dev is really responsive in fixing issues and introducing useful enhancements. And the upstream zrepl dev does not seem to be willing integrate these changes.
hostmakedepends = ["go"] | ||
depends = ["zfs"] | ||
provides = [self.with_pkgver("zrepl")] | ||
pkgdesc = "One-stop ZFS backup & replication solution - dsh2dsh enhanced fork" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ZFS backup and replication tool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fork info is probably needed here. This is not the original zrepl. This message is copied directly from FreeBSD port.
url = "https://github.com/dsh2dsh/zrepl" | ||
source = f"{url}/archive/v{pkgver}.tar.gz" | ||
sha256 = "1262c854c32e66cf67dd1d8c2ca6e546b6d42100c9bca9857ba37b6a16a5b1d1" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this extra newline does not belong here
|
||
def install(self): | ||
self.install_bin("build/zrepl") | ||
self.install_file("dist/freebsd/etc/zrepl/zrepl.yml", "etc/zrepl", name="zrepl.yml.sample") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
examples don't go in /etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may also change it to be zrepl.yml as an default config. But I feel it is more like a sample than default config to be used as is.
@@ -0,0 +1,3 @@ | |||
# Directory for control socket | |||
|
|||
d /run/zrepl 0755 root root - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it can't create it by itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. It fails without that. I'll file that as a bug. The default is /var/run/zrepl/control, but it may be changed in the config.
This is an enhanced fork of the original zrepl ZFS snapshot and replication daemon.
The package builds and works as expected on x86_64 and it contains everything that is needed to properly use on Chimera.