Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename route "type" to "behavior" #15

Merged
merged 1 commit into from
Feb 26, 2019
Merged

Rename route "type" to "behavior" #15

merged 1 commit into from
Feb 26, 2019

Conversation

lcobucci
Copy link
Member

Since we have plans to allow people to register services that are already a PSR-15 request handler, this is a more explicit name for the attribute.

@lcobucci
Rename route "type" to "behavior"
d082b68 
Since we have plans to allow people to register services that are
already a PSR-15 request handler, this is a more explicit name for the
attribute.
@lcobucci lcobucci added Improvement Improvement of existing feature BC-Break This issue or pull request breaks backwards compatibility labels Feb 26, 2019
@lcobucci lcobucci added this to the v0.2.0 milestone Feb 26, 2019
@lcobucci lcobucci self-assigned this Feb 26, 2019
@lcobucci lcobucci merged commit e641e8c into master Feb 26, 2019
@lcobucci lcobucci deleted the rename-route-type-attribute branch February 26, 2019 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdohms rdohms rdohms approved these changes

@frankkoornstra frankkoornstra Awaiting requested review from frankkoornstra

@dsantang dsantang Awaiting requested review from dsantang

Assignees

@lcobucci lcobucci

Labels
BC-Break This issue or pull request breaks backwards compatibility Improvement Improvement of existing feature
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lcobucci @rdohms