Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement functional tests #83

Merged
merged 4 commits into from
Feb 18, 2021
Merged

Implement functional tests #83

merged 4 commits into from
Feb 18, 2021

Conversation

lcobucci
Copy link
Member

@lcobucci lcobucci commented Feb 7, 2021

This adds functional tests to verify that the registration of the components works as expected and that the generated application actually runs.

@lcobucci lcobucci added the Improvement Improvement of existing feature label Feb 7, 2021
@lcobucci lcobucci added this to the 0.4.0 milestone Feb 7, 2021
@lcobucci lcobucci self-assigned this Feb 7, 2021
@rdohms
Copy link
Contributor

rdohms commented Feb 8, 2021

Looks good so far 👍

Definitions can also point to interfaces, so we cannot assume that it
will always be a class.
@lcobucci lcobucci force-pushed the implement-functional-tests branch 3 times, most recently from fed2593 to 71c50b7 Compare February 18, 2021 22:48
Lock file operations: 0 installs, 9 updates, 0 removals
  - Upgrading chimera/serialization-jms (0.4.x-dev 8c1bc41 => 0.4.x-dev 1ead176)
  - Upgrading league/tactician (v1.0.3 => v1.1.0)
  - Upgrading phpstan/phpstan (0.12.72 => 0.12.77)
  - Upgrading symfony/polyfill-ctype (v1.22.0 => v1.22.1)
  - Upgrading symfony/polyfill-intl-grapheme (v1.22.0 => v1.22.1)
  - Upgrading symfony/polyfill-intl-normalizer (v1.22.0 => v1.22.1)
  - Upgrading symfony/polyfill-mbstring (v1.22.0 => v1.22.1)
  - Upgrading symfony/polyfill-php73 (v1.22.0 => v1.22.1)
  - Upgrading symfony/polyfill-php80 (v1.22.0 => v1.22.1)
@lcobucci lcobucci force-pushed the implement-functional-tests branch from 71c50b7 to 9f5091d Compare February 18, 2021 22:50
@lcobucci lcobucci marked this pull request as ready for review February 18, 2021 22:52
@lcobucci
Copy link
Member Author

@rdohms I've added here the services you've mentioned on #43, this should provide us with a better foundation to continue there.

@lcobucci lcobucci merged commit a8ccc41 into 0.4.x Feb 18, 2021
@lcobucci lcobucci deleted the implement-functional-tests branch February 18, 2021 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Improvement of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants