Use simplified command handler #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lock file operations: 0 installs, 3 updates, 1 removal - Removing league/tactician-container (2.0.0) - Upgrading chimera/bus-tactician (0.4.x-dev a0b732c => 0.4.x-dev 0134905) - Upgrading doctrine/annotations (1.11.1 => 1.12.0) - Upgrading phpstan/phpstan (0.12.77 => 0.12.78)
This reduces the amount of components being called to process a command/query by relying on a simplified command handler. That implementation uses a static list of service+method, indexed by the FQCN of the message being processed.
These are no longer being used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the application registration use a command handler provided by
chimera/bus-tactician, which removes some method calls and allows us to name methods on handlers according to the needs - instead of forcing some convention...