Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verification library code. #17

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Add verification library code. #17

merged 1 commit into from
Mar 6, 2023

Conversation

zhalvorsen
Copy link
Contributor

A golang library and test suite has been added to start testing DPE end to end. There will need to be a layer added to abstract the transport layer and allow testing with devices as well as the simulator. Currently the simulator is the only working option.

@zhalvorsen
Copy link
Contributor Author

@jhand2 is this the direction you wanted to go with the verification library? Feel free to put my changes back into your branch and start a PR. I can take the go files out of this PR.

Output from DPE simulator:

 ~/caliptra/dpe/simulator
$ cargo run
    Finished dev [unoptimized + debuginfo] target(s) in 0.03s
     Running `target/debug/simulator`
DPE listening to socket /tmp/dpe-sim.socket
----------------------------------
| GetProfile
|
| 0
----------------------------------
----------------------------------
| InitCtx(InitCtxCmd { flags: 1073741824 })
|
| 0
----------------------------------

Output from go tests:

 ~/caliptra/dpe/verification
$ go test
PASS
ok      dpe/verification        0.023s 

@zhalvorsen zhalvorsen requested review from jhand2 and ia0 March 6, 2023 16:16
@zhalvorsen zhalvorsen marked this pull request as ready for review March 6, 2023 16:17
ia0
ia0 previously approved these changes Mar 6, 2023
Copy link
Contributor

@ia0 ia0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check the Go code.

simulator/src/main.rs Outdated Show resolved Hide resolved
ia0
ia0 previously approved these changes Mar 6, 2023
ia0
ia0 previously approved these changes Mar 6, 2023
simulator/src/main.rs Outdated Show resolved Hide resolved
@zhalvorsen zhalvorsen force-pushed the zh/simulator branch 2 times, most recently from 71d41a7 to 1fd2be9 Compare March 6, 2023 17:38
simulator/src/main.rs Outdated Show resolved Hide resolved
verification/client.go Outdated Show resolved Hide resolved
ia0
ia0 previously approved these changes Mar 6, 2023
@zhalvorsen zhalvorsen force-pushed the zh/simulator branch 2 times, most recently from ef0ff3a to 351bb57 Compare March 6, 2023 19:37
jhand2
jhand2 previously approved these changes Mar 6, 2023
verification/abi.go Outdated Show resolved Hide resolved
ia0
ia0 previously approved these changes Mar 6, 2023
simulator/src/main.rs Outdated Show resolved Hide resolved
A golang library and test suite has been added to start testing DPE
end to end. There will need to be a layer added to abstract the
transport layer and allow testing with devices as well as the simulator.
Currently the simulator is the only working option.
@zhalvorsen zhalvorsen dismissed stale reviews from ia0 and jhand2 via 67600bd March 6, 2023 20:36
@jhand2 jhand2 merged commit 14e5f70 into main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants