-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add verification library code. #17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jhand2 is this the direction you wanted to go with the verification library? Feel free to put my changes back into your branch and start a PR. I can take the go files out of this PR. Output from DPE simulator:
Output from go tests:
|
ia0
previously approved these changes
Mar 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't check the Go code.
ia0
previously approved these changes
Mar 6, 2023
ia0
previously approved these changes
Mar 6, 2023
zhalvorsen
force-pushed
the
zh/simulator
branch
2 times, most recently
from
March 6, 2023 17:38
71d41a7
to
1fd2be9
Compare
jhand2
reviewed
Mar 6, 2023
ia0
previously approved these changes
Mar 6, 2023
zhalvorsen
force-pushed
the
zh/simulator
branch
2 times, most recently
from
March 6, 2023 19:37
ef0ff3a
to
351bb57
Compare
jhand2
previously approved these changes
Mar 6, 2023
ia0
previously approved these changes
Mar 6, 2023
A golang library and test suite has been added to start testing DPE end to end. There will need to be a layer added to abstract the transport layer and allow testing with devices as well as the simulator. Currently the simulator is the only working option.
ia0
approved these changes
Mar 6, 2023
jhand2
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A golang library and test suite has been added to start testing DPE end to end. There will need to be a layer added to abstract the transport layer and allow testing with devices as well as the simulator. Currently the simulator is the only working option.