Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate strongenum annos #2240

Closed
wants to merge 1 commit into from
Closed

Conversation

sequencer
Copy link
Member

@sequencer sequencer commented Nov 8, 2021

No description provided.

@sequencer sequencer changed the base branch from master to 3.4.x November 8, 2021 00:38
@sequencer sequencer force-pushed the deprecate_strongenum_annos branch from fecca76 to db139c4 Compare November 8, 2021 00:40
@sequencer sequencer added this to the 3.3.x milestone Nov 8, 2021
@sequencer sequencer requested a review from jackkoenig November 8, 2021 00:40
@sequencer sequencer mentioned this pull request Nov 8, 2021
14 tasks
@jackkoenig jackkoenig modified the milestones: 3.3.x, 3.4.x Nov 12, 2021
@jackkoenig
Copy link
Contributor

This is fine to merge once we've merged the other, related PRs

Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we're now so related in the 3.5 release process, we should instead deprecate in 3.5. Sorry for now helping this catch the train but we don't want 3.5.0 to slip any more.

@sequencer
Copy link
Member Author

Sure. I'll deprecate it in 3.5

@sequencer sequencer modified the milestones: 3.4.x, 3.5.0 Dec 21, 2021
@sequencer sequencer closed this Dec 21, 2021
@sequencer
Copy link
Member Author

Work on this in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants