Share ChildBinding objects between siblings (backport #4238) #4241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's hard to measure the benefit from this, but I used the following little snippet of Chisel to make a bundle of Bundles:
Then I built a fat assembly jar with Mill, and checked the heap size with
find_heap_bound
:With this, I measured a ~2.5% memory reduction for this very Bundle-heavy code.
I had thought about a more aggressive change, where
ChildBinding
becomes acase object
and we instead get theparent
fromref
(which does duplicate this information). However, using the above benchmark, I measured the exact same memory improvement. Since I cannot measure any benefit from the much more aggressive and hacky alternative approach, I think we should do the simpler thing which gets more-or-less the same benefit.Contributor Checklist
docs/src
?Type of Improvement
Desired Merge Strategy
Release Notes
This reduces memory use by
n - 1
times 16-bytes for an Aggregate withn
elements.Reviewer Checklist (only modified by reviewer)
3.6.x
,5.x
, or6.x
depending on impact, API modification or big change:7.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.This is an automatic backport of pull request #4238 done by [Mergify](https://mergify.com).