Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share Node objects between siblings #4259

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Share Node objects between siblings #4259

merged 1 commit into from
Jul 11, 2024

Conversation

jackkoenig
Copy link
Contributor

Similar to #4238 (and reflecting our redundant representation--binding and ref)

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Performance improvement

Desired Merge Strategy

  • Squash

Release Notes

This reduces memory use by n - 1 times 16-bytes for an Aggregate with n elements.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the Performance Improves performance, will be included in release notes label Jul 9, 2024
@jackkoenig jackkoenig added this to the 6.x milestone Jul 9, 2024
@jackkoenig jackkoenig mentioned this pull request Jul 10, 2024
Merged
14 tasks
@jackkoenig jackkoenig merged commit a60f981 into main Jul 11, 2024
18 checks passed
@jackkoenig jackkoenig deleted the jackkoenig/share-parent-node branch July 11, 2024 18:32
@mergify mergify bot added the Backported This PR has been backported label Jul 11, 2024
mergify bot pushed a commit that referenced this pull request Jul 11, 2024
@jackkoenig @mergify
Share Node objects between siblings (#4259)
d7b1238 
(cherry picked from commit a60f981)
@mergify mergify bot mentioned this pull request Jul 11, 2024
Merged
14 tasks
chiselbot pushed a commit that referenced this pull request Jul 11, 2024
@mergify @jackkoenig
Share Node objects between siblings (backport #4259) (#4272)
a2382c2 
* Share Node objects between siblings (#4259)

(cherry picked from commit a60f981)

* Waive binary dependency issues from package private changes

---------

Co-authored-by: Jack Koenig <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@mergify mergify bot mentioned this pull request Jul 11, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azidar azidar azidar approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported Performance Improves performance, will be included in release notes
Projects
None yet
Milestone
6.x
Development

Successfully merging this pull request may close these issues.
2 participants
@jackkoenig @azidar