Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Try to enable binder tests #4361

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

SpriteOvO
Copy link
Member

No description provided.

@SpriteOvO SpriteOvO changed the title [binder] Refactor value cache [ci] Try to enable binder tests Aug 20, 2024
@SpriteOvO SpriteOvO force-pushed the binder-refactor-value-cache branch 7 times, most recently from 1de1639 to 4e3c260 Compare August 20, 2024 16:52
@github-actions github-actions bot force-pushed the ci/ci-circt-nightly branch 2 times, most recently from 9bfc7f4 to 2897944 Compare August 22, 2024 11:05
@SpriteOvO SpriteOvO force-pushed the binder-refactor-value-cache branch 2 times, most recently from a1538b0 to 2d51551 Compare September 3, 2024 18:30
@SpriteOvO SpriteOvO force-pushed the binder-refactor-value-cache branch 2 times, most recently from e9917c5 to 6b9222f Compare September 3, 2024 19:08
@SpriteOvO SpriteOvO force-pushed the binder-refactor-value-cache branch 5 times, most recently from 7a57053 to 6682da5 Compare September 3, 2024 22:50
@jackkoenig
Copy link
Contributor

Why is this PR against nightly instead of main?

@SpriteOvO
Copy link
Member Author

The required C-API was still in nightly when this PR was created, but now we can change it to be based on main. 👍

@SpriteOvO SpriteOvO changed the base branch from ci/ci-circt-nightly to main September 4, 2024 23:37
@SpriteOvO SpriteOvO force-pushed the binder-refactor-value-cache branch 3 times, most recently from 86c7222 to aabacc4 Compare September 5, 2024 00:40
@jackkoenig
Copy link
Contributor

I'm unsure what Scala-CLI issue you're running into, but I've had issues with Scala-CLI hanging in Github Actions: VirtusLab/scala-cli#3054

Also VirtusLab/scala-cli#3013 about Scala CLI downloading its own Java (although that has to do with the scala-cli action so may not apply).

@SpriteOvO
Copy link
Member Author

SpriteOvO commented Sep 5, 2024

I'm unsure what Scala-CLI issue you're running into

scala-cli complains java.nio.file.FileAlreadyExistsException: /home/runner/.cache/scalacli/local-repo/.1.5.0.tmp/version.

rm this file before running mill doesn't help, there seems to be another process creating this file. It's not even fully reproducible, it just happens randomly. 🤦

I have reported this issue VirtusLab/scala-cli#3110, but the maintainers say they don't have a clue unless I can provide a minimum reproducible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants