This repository has been archived by the owner on Aug 20, 2024. It is now read-only.
Add SortModules Transform #1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seldridge
requested review from
albert-magyar
and removed request for
a team
Adds a new transform, SortModules, that transforms a FIRRTL circuit to enforce an invariant of modules and external modules being defined before use. This transform is left as optional in the event that a user may wish to have a quick way of getting the circuit to respect this property as may be expected of some other tool, e.g., MLIR. Signed-off-by: Schuyler Eldridge <[email protected]>
Signed-off-by: Schuyler Eldridge <[email protected]>
seldridge
force-pushed
the
sort-modules-transform
branch
from
9393eaa
to
5e9e0bc
Compare
jackkoenig
approved these changes
Nov 30, 2020
jackkoenig
added
the
Please Merge
mergify bot
pushed a commit
that referenced
this pull request
Nov 30, 2020
* Add SortModules to transform to def-before-use Adds a new transform, SortModules, that transforms a FIRRTL circuit to enforce an invariant of modules and external modules being defined before use. This transform is left as optional in the event that a user may wish to have a quick way of getting the circuit to respect this property as may be expected of some other tool, e.g., MLIR. Signed-off-by: Schuyler Eldridge <[email protected]> * Add test of SortModules transform Signed-off-by: Schuyler Eldridge <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 4e46f8c)
mergify
bot
added
the
Backported
mergify bot
added a commit
that referenced
this pull request
Nov 30, 2020
* Add SortModules to transform to def-before-use Adds a new transform, SortModules, that transforms a FIRRTL circuit to enforce an invariant of modules and external modules being defined before use. This transform is left as optional in the event that a user may wish to have a quick way of getting the circuit to respect this property as may be expected of some other tool, e.g., MLIR. Signed-off-by: Schuyler Eldridge <[email protected]> * Add test of SortModules transform Signed-off-by: Schuyler Eldridge <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 4e46f8c) Co-authored-by: Schuyler Eldridge <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new transform,
SortModules, that will convert a FIRRTL circuit into def-before-use of modules and external modules.The Scala FIRRTL compiler isn't particularly picky about this, but other downstream tooling may be.
This transform is not used, but is only provided such that a user can either include it if they want this invariant in their code or if they want a quick way to convert a FIRRTL circuit to respect this property, e.g., :
Contributor Checklist
Type of Improvement
API Impact
None. Pure feature addition.
Backend Code Generation Impact
None. The new transform is optional.
Desired Merge Strategy
Release Notes
Add optional SortModules transform to enforce define-before-use of modules/extmodules.
Reviewer Checklist (only modified by reviewer)
Please Merge?