Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

-full64 is required to detect VCS. #1930

Merged
merged 1 commit into from
Nov 7, 2020
Merged

-full64 is required to detect VCS. #1930

merged 1 commit into from
Nov 7, 2020

Conversation

sequencer
Copy link
Member

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you update the FIRRTL spec to include every new feature/behavior?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

API Impact

None

Backend Code Generation Impact

None

Desired Merge Strategy

  • Rebase: You will rebase the PR onto master and it will be merged with a merge commit.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@sequencer sequencer requested a review from a team as a code owner October 22, 2020 00:47
@sequencer sequencer requested review from albertchen-sifive and removed request for a team October 22, 2020 00:47
@azidar azidar added this to the 1.3.x milestone Nov 2, 2020
@azidar azidar added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Nov 2, 2020
@sequencer
Copy link
Member Author

Just did the scalafmt and rebase to origin/master. Is should pass now.

@mergify mergify bot merged commit 1d0b113 into master Nov 7, 2020
mergify bot pushed a commit that referenced this pull request Nov 7, 2020
@sequencer
-full64 is required to detect VCS. (#1930)
a6b968b 
(cherry picked from commit 1d0b113)

# Conflicts:
#	src/main/scala/firrtl/FileUtils.scala
@mergify mergify bot mentioned this pull request Nov 7, 2020
Merged
mergify bot pushed a commit that referenced this pull request Nov 7, 2020
@sequencer
-full64 is required to detect VCS. (#1930)
79dad26 
(cherry picked from commit 1d0b113)
@mergify mergify bot mentioned this pull request Nov 7, 2020
Merged
@mergify mergify bot added the Backported This PR has been backported to marked stable branch label Nov 7, 2020
mergify bot added a commit that referenced this pull request Nov 7, 2020
@mergify @sequencer
-full64 is required to detect VCS. (#1930) (#1941)
2724268 
(cherry picked from commit 1d0b113)

Co-authored-by: Jiuyang Liu <[email protected]>
mergify bot added a commit that referenced this pull request Nov 9, 2020
@mergify @sequencer @azidar
-full64 is required to detect VCS. (bp #1930) (#1940)
694dfcf 
* -full64 is required to detect VCS. (#1930)

(cherry picked from commit 1d0b113)

# Conflicts:
#	src/main/scala/firrtl/FileUtils.scala

* Update FileUtils.scala

Co-authored-by: Jiuyang Liu <[email protected]>
Co-authored-by: Adam Izraelevitz <[email protected]>
@jackkoenig jackkoenig deleted the utils-patch branch December 2, 2020 18:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackkoenig jackkoenig jackkoenig left review comments

@azidar azidar azidar approved these changes

@albertchen-sifive albertchen-sifive Awaiting requested review from albertchen-sifive

Assignees
No one assigned
Labels
Backported This PR has been backported to marked stable branch Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Milestone
1.3.x
Development

Successfully merging this pull request may close these issues.
3 participants
@sequencer @azidar @jackkoenig