Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

smt: ensure that all signals have a unique name #1943

Merged
merged 2 commits into from
Nov 9, 2020
Merged

smt: ensure that all signals have a unique name #1943

merged 2 commits into from
Nov 9, 2020

Conversation

ekiwi
Copy link
Contributor

@ekiwi ekiwi commented Nov 9, 2020

Contributor Checklist

  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?

Type of Improvement

  • bug fix

Backend Code Generation Impact

  • more designs actually make it to the backend instead of failing to serialize

Desired Merge Strategy

  • suqash

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@ekiwi ekiwi requested a review from a team as a code owner November 9, 2020 21:03
@ekiwi ekiwi requested review from albert-magyar and removed request for a team November 9, 2020 21:03
@ekiwi ekiwi requested review from jackkoenig and removed request for albert-magyar November 9, 2020 21:04
@ekiwi ekiwi added the bugfix label Nov 9, 2020
@ekiwi ekiwi added this to the 1.4.0 milestone Nov 9, 2020
@ekiwi ekiwi added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Nov 9, 2020
@mergify mergify bot merged commit fe95544 into chipsalliance:master Nov 9, 2020
@ekiwi
Copy link
Contributor Author

ekiwi commented Nov 10, 2020

@Mergifyio backport 1.4.x

mergify bot pushed a commit that referenced this pull request Nov 10, 2020
@ekiwi
smt: ensure that all signals have a unique name (#1943)
235097a 
* smt: add tests for assert name clashes

* smt: ensure unique signal names with a namespace

this fixes issues #1934

(cherry picked from commit fe95544)
@mergify mergify bot mentioned this pull request Nov 10, 2020
Merged
@mergify
Copy link
Contributor

mergify bot commented Nov 10, 2020

Command backport 1.4.x: success

Backports have been created

mergify bot added a commit that referenced this pull request Nov 11, 2020
@mergify @ekiwi
smt: ensure that all signals have a unique name (#1943) (#1946)
0e7ccf2 
* smt: add tests for assert name clashes

* smt: ensure unique signal names with a namespace

this fixes issues #1934

(cherry picked from commit fe95544)

Co-authored-by: Kevin Laeufer <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@azidar azidar azidar approved these changes

@jackkoenig jackkoenig Awaiting requested review from jackkoenig

Assignees
No one assigned
Labels
bugfix Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ekiwi @azidar