This repository has been archived by the owner on Aug 20, 2024. It is now read-only.
Fix RemoveWires handling of invalidated non-UInt wires #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the swift resolution! |
|
CI failure is flaky Chisel tests which will be resolved shortly: chipsalliance/chisel#1661 |
seldridge
approved these changes
Nov 11, 2020
jackkoenig
added
the
Please Merge
It would replace them with a validif node with a UIntLiteral which can lead to type errors.
jackkoenig
force-pushed
the
fix-remove-wires-isinvalid-type
branch
from
6063bf7
to
155647c
Compare
mergify bot
pushed a commit
that referenced
this pull request
Nov 12, 2020
It would replace them with a validif node with a UIntLiteral which can lead to type errors. (cherry picked from commit c7bbb75) # Conflicts: # src/main/scala/firrtl/passes/RemoveValidIf.scala # src/main/scala/firrtl/transforms/RemoveWires.scala # src/test/scala/firrtlTests/RemoveWiresSpec.scala
mergify bot
pushed a commit
that referenced
this pull request
Nov 12, 2020
It would replace them with a validif node with a UIntLiteral which can lead to type errors. (cherry picked from commit c7bbb75) # Conflicts: # src/main/scala/firrtl/passes/RemoveValidIf.scala # src/main/scala/firrtl/transforms/RemoveWires.scala
mergify bot
pushed a commit
that referenced
this pull request
Nov 12, 2020
It would replace them with a validif node with a UIntLiteral which can lead to type errors. (cherry picked from commit c7bbb75)
mergify
bot
added
the
Backported
mergify bot
added a commit
that referenced
this pull request
Nov 12, 2020
It would replace them with a validif node with a UIntLiteral which can lead to type errors. (cherry picked from commit c7bbb75) Co-authored-by: Jack Koenig <[email protected]>
5 tasks
mergify bot
added a commit
that referenced
this pull request
Mar 20, 2021
) * Fix RemoveWires handling of invalidated non-UInt wires (#1949) It would replace them with a validif node with a UIntLiteral which can lead to type errors. (cherry picked from commit c7bbb75) # Conflicts: # src/main/scala/firrtl/passes/RemoveValidIf.scala # src/main/scala/firrtl/transforms/RemoveWires.scala # src/test/scala/firrtlTests/RemoveWiresSpec.scala * Resolve conflicts Co-authored-by: Jack Koenig <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot
added a commit
that referenced
this pull request
Mar 20, 2021
) * Fix RemoveWires handling of invalidated non-UInt wires (#1949) It would replace them with a validif node with a UIntLiteral which can lead to type errors. (cherry picked from commit c7bbb75) # Conflicts: # src/main/scala/firrtl/passes/RemoveValidIf.scala # src/main/scala/firrtl/transforms/RemoveWires.scala * Resolve conflicts Co-authored-by: Jack Koenig <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would replace them with a validif node with a UIntLiteral which can
lead to type errors.
h/t @aswaterman for finding and helping identify the bug
Contributor Checklist
Type of Improvement
API Impact
New API for getting zero of any
GroundType, really an improvement on what existed inRemoveValidIf.Backend Code Generation Impact
No impact
Desired Merge Strategy
Release Notes
Fix handling of non-UInt ground types with no connection
Reviewer Checklist (only modified by reviewer)
Please Merge?