Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

Automatically publish SNAPSHOTs on pushes to master #1955

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

jackkoenig
Copy link
Contributor

@jackkoenig jackkoenig commented Nov 12, 2020

Uses sbt-ci-release for automation. Any push to the specific branches (ie. a CI run after a PR is merged) will push SNAPSHOTs to the Sonatype snapshot repository. This is set up for master and all stable branches (See the regex: /^\d+\.\d+\.x$/)

The affected branches:

branch SNAPSHOT
master 1.5-SNAPSHOT
1.4.x 1.4-SNAPSHOT
1.3.x 1.3-SNAPSHOT
1.2.x 1.2-SNAPSHOT

Backports will likely conflict and need fixup.

Contributor Checklist

  • [NA] Did you add Scaladoc to every public function/method?
  • [NA] Did you update the FIRRTL spec to include every new feature/behavior?
  • [😬 ] Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • [NA] Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • automation

API Impact

No impact

Backend Code Generation Impact

No impact

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@jackkoenig jackkoenig requested a review from a team as a code owner November 12, 2020 00:40
@jackkoenig jackkoenig requested review from albertchen-sifive and chick and removed request for a team and albertchen-sifive November 12, 2020 00:40
@jackkoenig
Copy link
Contributor Author

jackkoenig commented Nov 12, 2020

It worked! 1.5-SNAPSHOT was pushed for 2.11, 2.12, and 2.13 by this PR (Note the commented out line in the .travis.yml, normally only pushes should do the publishing).

https://oss.sonatype.org/#nexus-search;gav~edu.berkeley.cs~firrtl_2.12~~~~kw,versionexpand

Uses sbt-ci-release for automation
Copy link
Contributor

@chick chick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks like a nice small change. All looks ok to me.
See the comment about the comparsion operators in .travis.yml:36 file

- name: prepare
- name: test
- name: release
if: ((branch = master) OR (branch =~ /^\d+\.\d+\.x$/)) AND (type = push) AND (NOT fork)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this is the correct equals here. It's a syntax diversity meeting here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's right but we shall see, got this from https://docs.travis-ci.com/user/conditions-v1

@jackkoenig jackkoenig merged commit 06843bd into master Nov 12, 2020
mergify bot pushed a commit that referenced this pull request Nov 12, 2020
Uses sbt-ci-release for automation

(cherry picked from commit 06843bd)

# Conflicts:
#	.travis.yml
#	build.sbt
#	project/plugins.sbt
mergify bot pushed a commit that referenced this pull request Nov 12, 2020
Uses sbt-ci-release for automation

(cherry picked from commit 06843bd)

# Conflicts:
#	.travis.yml
#	project/plugins.sbt
mergify bot pushed a commit that referenced this pull request Nov 12, 2020
Uses sbt-ci-release for automation

(cherry picked from commit 06843bd)

# Conflicts:
#	.travis.yml
#	project/plugins.sbt
@mergify mergify bot added the Backported This PR has been backported to marked stable branch label Nov 12, 2020
mergify bot added a commit that referenced this pull request Nov 12, 2020
* Automatically publish SNAPSHOTs on pushes to master (#1955)

Uses sbt-ci-release for automation

(cherry picked from commit 06843bd)

# Conflicts:
#	.travis.yml
#	project/plugins.sbt

* Fix merge conflicts

Co-authored-by: Jack Koenig <[email protected]>
mergify bot added a commit that referenced this pull request Nov 13, 2020
* Automatically publish SNAPSHOTs on pushes to master (#1955)

Uses sbt-ci-release for automation

(cherry picked from commit 06843bd)

# Conflicts:
#	.travis.yml
#	project/plugins.sbt

* Resolve merge conflicts

Co-authored-by: Jack Koenig <[email protected]>
mergify bot added a commit that referenced this pull request Nov 13, 2020
* Automatically publish SNAPSHOTs on pushes to master (#1955)

Uses sbt-ci-release for automation

(cherry picked from commit 06843bd)

# Conflicts:
#	.travis.yml
#	build.sbt
#	project/plugins.sbt

* Resolve merge conflicts

Co-authored-by: Jack Koenig <[email protected]>
@jackkoenig jackkoenig deleted the sbt-ci-release branch November 18, 2020 19:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Backported This PR has been backported to marked stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants