Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

Fix Type Error fuzzer Example code #1960

Merged
merged 2 commits into from
Nov 17, 2020
Merged

Fix Type Error fuzzer Example code #1960

merged 2 commits into from
Nov 17, 2020

Conversation

kimdh727
Copy link
Contributor

@kimdh727 kimdh727 commented Nov 15, 2020 •
edited
Loading

Seq[(Int, DoPrimGen)] to Map[ExprGen[_ <: Expression], Int]

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you update the FIRRTL spec to include every new feature/behavior?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

bug fix

API Impact

Backend Code Generation Impact

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference.

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@kimdh727
Fix Type Error fuzzer Example code
0264a27 
Seq[(Int, DoPrimGen)] to Map[ExprGen[_ <: Expression], Int]
@kimdh727 kimdh727 requested a review from a team as a code owner November 15, 2020 09:51
@kimdh727 kimdh727 requested review from seldridge and removed request for a team November 15, 2020 09:51
@CLAassistant
Copy link

CLAassistant commented Nov 15, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@azidar
Copy link
Contributor

azidar commented Nov 16, 2020

Can we add compiling this project into CI, so we can detect these failures in the future?

@kimdh727
Copy link
Contributor Author

@azidar I got compile error on intellij IDEA

@kimdh727
Copy link
Contributor Author

@albertchen-sifive How Can I Merge this PR? I Don't have permission about merge it

@albertchen-sifive albertchen-sifive added this to the 1.4.x milestone Nov 17, 2020
@albertchen-sifive albertchen-sifive added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Nov 17, 2020
@mergify mergify bot merged commit d645921 into chipsalliance:master Nov 17, 2020
mergify bot pushed a commit that referenced this pull request Nov 17, 2020
@kimdh727
Fix Type Error fuzzer Example code (#1960)
585efe8 
Seq[(Int, DoPrimGen)] to Map[ExprGen[_ <: Expression], Int]

(cherry picked from commit d645921)
@mergify mergify bot mentioned this pull request Nov 17, 2020
Merged
@mergify mergify bot added the Backported This PR has been backported to marked stable branch label Nov 17, 2020
mergify bot added a commit that referenced this pull request Nov 17, 2020
@mergify @kimdh727
Fix Type Error fuzzer Example code (#1960) (#1970)
508a392 
Seq[(Int, DoPrimGen)] to Map[ExprGen[_ <: Expression], Int]

(cherry picked from commit d645921)

Co-authored-by: JADE KIM <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@albertchen-sifive albertchen-sifive albertchen-sifive approved these changes

@seldridge seldridge Awaiting requested review from seldridge

Assignees
No one assigned
Labels
Backported This PR has been backported to marked stable branch Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Milestone
1.4.x
Development

Successfully merging this pull request may close these issues.
4 participants
@kimdh727 @CLAassistant @azidar @albertchen-sifive