Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

fix scaladoc for ReferenceTarget #2014

Merged
merged 2 commits into from
Dec 11, 2020
Merged

fix scaladoc for ReferenceTarget #2014

merged 2 commits into from
Dec 11, 2020

Conversation

mwachs5
Copy link
Contributor

@mwachs5 mwachs5 commented Dec 9, 2020 •
edited
Loading

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you update the FIRRTL spec to include every new feature/behavior?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • bug fix
  • documentation

API Impact

No impact on the existing API

Backend Code Generation Impact

No impact

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference.

Release Notes

Fix misleading information in scaladoc for ReferenceTarget

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@CLAassistant
Copy link

CLAassistant commented Dec 9, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jackkoenig jackkoenig added this to the 1.2.X milestone Dec 11, 2020
@jackkoenig jackkoenig added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Dec 11, 2020
@mergify mergify bot merged commit 93869cc into chipsalliance:master Dec 11, 2020
mergify bot pushed a commit that referenced this pull request Dec 11, 2020
@mwachs5
fix scaladoc for ReferenceTarget (#2014)
01fb692 
(cherry picked from commit 93869cc)
@mergify mergify bot mentioned this pull request Dec 11, 2020
Merged
mergify bot pushed a commit that referenced this pull request Dec 11, 2020
@mwachs5
fix scaladoc for ReferenceTarget (#2014)
f8f411c 
(cherry picked from commit 93869cc)
@mergify mergify bot mentioned this pull request Dec 11, 2020
Merged
mergify bot pushed a commit that referenced this pull request Dec 11, 2020
@mwachs5
fix scaladoc for ReferenceTarget (#2014)
18a7d57 
(cherry picked from commit 93869cc)
@mergify mergify bot mentioned this pull request Dec 11, 2020
Merged
@mergify mergify bot added the Backported This PR has been backported to marked stable branch label Dec 11, 2020
mergify bot added a commit that referenced this pull request Dec 11, 2020
@mergify @mwachs5
fix scaladoc for ReferenceTarget (#2014) (#2018)
325b0eb 
(cherry picked from commit 93869cc)

Co-authored-by: Megan Wachs <[email protected]>
mergify bot added a commit that referenced this pull request Dec 11, 2020
@mergify @mwachs5
fix scaladoc for ReferenceTarget (#2014) (#2019)
0d21de8 
(cherry picked from commit 93869cc)

Co-authored-by: Megan Wachs <[email protected]>
mergify bot added a commit that referenced this pull request Dec 11, 2020
@mergify @mwachs5
fix scaladoc for ReferenceTarget (#2014) (#2020)
113e39c 
(cherry picked from commit 93869cc)

Co-authored-by: Megan Wachs <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackkoenig jackkoenig jackkoenig approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported to marked stable branch Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Milestone
1.2.x
Development

Successfully merging this pull request may close these issues.
3 participants
@mwachs5 @CLAassistant @jackkoenig