This repository has been archived by the owner on Aug 20, 2024. It is now read-only.
Deprecate ToWorkingIR #2028
Merged
Deprecate ToWorkingIR #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate ToWorkingIR as it is now an identity transform. Signed-off-by: Schuyler Eldridge <[email protected]>
Signed-off-by: Schuyler Eldridge <[email protected]>
Signed-off-by: Schuyler Eldridge <[email protected]>
|
IR and WIR were merged in 1.4.0, so backporting to |
jackkoenig
approved these changes
Feb 1, 2021
jackkoenig
added
the
Please Merge
mergify bot
pushed a commit
that referenced
this pull request
Feb 1, 2021
* Deprecate firrtl.passes.ToWorkingIR Deprecate ToWorkingIR as it is now an identity transform. Signed-off-by: Schuyler Eldridge <[email protected]> * Deprecate firrtl.stage.Forms.WorkingIR Signed-off-by: Schuyler Eldridge <[email protected]> * Switch from Forms.WorkingIR to Forms.MinimalHighForm Signed-off-by: Schuyler Eldridge <[email protected]> Co-authored-by: Jack Koenig <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit fd5d442)
mergify
bot
added
the
Backported
mergify bot
added a commit
that referenced
this pull request
Feb 1, 2021
* Deprecate firrtl.passes.ToWorkingIR Deprecate ToWorkingIR as it is now an identity transform. Signed-off-by: Schuyler Eldridge <[email protected]> * Deprecate firrtl.stage.Forms.WorkingIR Signed-off-by: Schuyler Eldridge <[email protected]> * Switch from Forms.WorkingIR to Forms.MinimalHighForm Signed-off-by: Schuyler Eldridge <[email protected]> Co-authored-by: Jack Koenig <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit fd5d442) Co-authored-by: Schuyler Eldridge <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ToWorkingIRpass is an identity transform since Magyar combined WIR and IR. This PR deprecates it, removes it fromfirrtl.stage.Forms, and removes its specification as a dependency.Contributor Checklist
Type of Improvement
API Impact
None.
Backend Code Generation Impact
None.
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
Please Merge?