Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

Cleanup some warnings #2032

Merged
merged 3 commits into from
Jan 20, 2021
Merged

Cleanup some warnings #2032

merged 3 commits into from
Jan 20, 2021

Conversation

jackkoenig
Copy link
Contributor

This reduces the number of warnings from 105 to 58 on a main compile using Scala 2.12. More to do (some are harder), but at least it puts a dent in it.

On the ProtoBuf stuff, I added the mismatched case as a user error because those options values cannot be generated by FIRRTL (nor Chisel) so odds are those would show up with some future version of FIRRTL that adds new values to the enumeration which someone then tries to compile with an old version of FIRRTL.

Contributor Checklist

  • [NA] Did you add Scaladoc to every public function/method?
  • [NA] Did you update the FIRRTL spec to include every new feature/behavior?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • code cleanup

API Impact

No impact

Backend Code Generation Impact

No impact

Desired Merge Strategy

  • Squash

Release Notes

Cleanup some compile warnings

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@jackkoenig jackkoenig added this to the 1.4.x milestone Jan 5, 2021
@mwachs5
Copy link
Contributor

mwachs5 commented Jan 5, 2021

🎉

@jackkoenig
Copy link
Contributor Author

jackkoenig commented Jan 5, 2021 •
edited
Loading

I marked it with 1.4.x since it'll apply cleanly, older branches would harder

@jackkoenig jackkoenig added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Jan 20, 2021
@mergify mergify bot merged commit 031fe13 into master Jan 20, 2021
mergify bot pushed a commit that referenced this pull request Jan 20, 2021
@jackkoenig
Cleanup some warnings (#2032)
b5216b6 
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 031fe13)
@mergify mergify bot mentioned this pull request Jan 20, 2021
Merged
@mergify mergify bot added the Backported This PR has been backported to marked stable branch label Jan 20, 2021
mergify bot added a commit that referenced this pull request Jan 20, 2021
@mergify @jackkoenig
Cleanup some warnings (#2032) (#2051)
6020600 
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 031fe13)

Co-authored-by: Jack Koenig <[email protected]>
@jackkoenig jackkoenig deleted the cleanup-some-warnings branch January 26, 2021 20:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@seldridge seldridge seldridge approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported to marked stable branch Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Milestone
1.4.x
Development

Successfully merging this pull request may close these issues.
3 participants
@jackkoenig @mwachs5 @seldridge