This repository has been archived by the owner on Aug 20, 2024. It is now read-only.
Deprecate InlineCasts, add InlineAcrossCasts #2146
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To maintain binary compatibility, InlineAcrossCasts is just aliases to
the now deprecated InlineCasts. We can make the binary incompatible
change of renaming the class and object for 1.5.
I will do a follow on PR to do the actual class and object rename for 1.5 (might as well delete
LegalizeClocksTransform
then too).Contributor Checklist
Type of Improvement
API Impact
This deprecates
InlineCasts
, renaming it toInlineAcrossCasts
to make it more clear. This transform is very unlikely to be used.Backend Code Generation Impact
No impact
Desired Merge Strategy
Release Notes
Deprecate
InlineCasts
, renaming it toInlineAcrossCasts
Reviewer Checklist (only modified by reviewer)
Please Merge
?