Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

Deprecate InlineCasts, add InlineAcrossCasts #2146

Merged
merged 2 commits into from
Apr 6, 2021
Merged

Conversation

jackkoenig
Copy link
Contributor

To maintain binary compatibility, InlineAcrossCasts is just aliases to
the now deprecated InlineCasts. We can make the binary incompatible
change of renaming the class and object for 1.5.

I will do a follow on PR to do the actual class and object rename for 1.5 (might as well delete LegalizeClocksTransform then too).

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • [NA] Did you update the FIRRTL spec to include every new feature/behavior?
  • [NA] Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • documentation
  • code refactoring

API Impact

This deprecates InlineCasts, renaming it to InlineAcrossCasts to make it more clear. This transform is very unlikely to be used.

Backend Code Generation Impact

No impact

Desired Merge Strategy

  • Squash

Release Notes

Deprecate InlineCasts, renaming it to InlineAcrossCasts

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

To maintain binary compatibility, InlineAcrossCasts is just aliases to
the now deprecated InlineCasts. We can make the binary incompatible
change of renaming the class and object for 1.5.
@jackkoenig jackkoenig added this to the 1.4.x milestone Mar 20, 2021
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

I did not double check that all uses of InlineCastsTransform were properly migrated, though.

@jackkoenig
Copy link
Contributor Author

I did not double check that all uses of InlineCastsTransform were properly migrated, though.

I did 🙂

@jackkoenig jackkoenig added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Apr 6, 2021
@mergify mergify bot merged commit 9a3dcf7 into master Apr 6, 2021
mergify bot pushed a commit that referenced this pull request Apr 6, 2021
To maintain binary compatibility, InlineAcrossCasts is just aliases to
the now deprecated InlineCasts. We can make the binary incompatible
change of renaming the class and object for 1.5.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 9a3dcf7)
@mergify mergify bot added the Backported This PR has been backported to marked stable branch label Apr 6, 2021
mergify bot added a commit that referenced this pull request Apr 6, 2021
To maintain binary compatibility, InlineAcrossCasts is just aliases to
the now deprecated InlineCasts. We can make the binary incompatible
change of renaming the class and object for 1.5.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 9a3dcf7)

Co-authored-by: Jack Koenig <[email protected]>
@jackkoenig jackkoenig deleted the rename-inline-casts branch April 8, 2021 02:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Backported This PR has been backported to marked stable branch Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants