This repository has been archived by the owner on Aug 20, 2024. It is now read-only.
Add NoConstantPropagationAnnotation to disable constatnt propagation #2150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sequencer
commented
Mar 25, 2021
| new ShellOption[String]( | ||
| longOption = "dont-fold", | ||
| toAnnotationSeq = a => { | ||
| PrimOps | ||
| .builtinPrimOps | ||
| .map(op => op.toString -> op) | ||
| .toMap | ||
| .get(a) | ||
| .orElse(throw new OptionsException(s"Unknown primop '$a'. (Did you misspell it?)")) | ||
| .map(DisableFold(_)) | ||
| .toSeq | ||
| }, | ||
| helpText = "Disable folding of specific primitive operations", | ||
| helpValueName = Some("<primop>") | ||
| ) | ||
| ) |
There was a problem hiding this comment.
I move that ShellOption to here, for better consistency.
sequencer
force-pushed
the
no_const_prop_anno
branch
from
cffef6b
to
f4b56ae
Compare
seldridge
reviewed
Mar 25, 2021
sequencer
force-pushed
the
no_const_prop_anno
branch
from
a6cbc4c
to
302752d
Compare
seldridge
reviewed
Mar 25, 2021
There was a problem hiding this comment.
This is looking great, @sequencer!
I'm fine to merge this if we can get around the binary compatibility issue. I'd like this to get into 1.4.3 and not have to wait until 1.5.0 for this to show up. I'm also hesitant to waive binary compatibility checks for this.
sequencer
force-pushed
the
no_const_prop_anno
branch
2 times, most recently
from
233ccb5
to
f58195c
Compare
14 tasks
|
Thanks @seldridge, I just rebased the binary incompatible part to #2152. I think this PR is safe to merge now. |
sequencer
force-pushed
the
no_const_prop_anno
branch
from
f58195c
to
5cf7443
Compare
jackkoenig
approved these changes
Mar 26, 2021
jackkoenig
added
the
Please Merge
mergify
bot
added
the
Backported
mergify bot
added a commit
that referenced
this pull request
Mar 27, 2021
…2150) (#2158) * add --no-constant-propagation to disable constant propagation * add test * deprecate DisableFold. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit abeff01) Co-authored-by: Jiuyang Liu <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Checklist
Type of Improvement
API Impact
add
Backend Code Generation Impact
none
Desired Merge Strategy
Release Notes
--no-constant-propagation can be used to disable constant propagation.
Reviewer Checklist (only modified by reviewer)
Please Merge?