Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

Make MustDeduplicateAnnotation deletable #2215

Merged
merged 1 commit into from
May 4, 2021
Merged

Conversation

jackkoenig
Copy link
Contributor

@jackkoenig jackkoenig commented May 4, 2021

Contributor Checklist

  • [NA] Did you add Scaladoc to every public function/method?
  • [NA] Did you update the FIRRTL spec to include every new feature/behavior?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • bug fix

API Impact

This expands the API to allow MustDeduplicateAnnotation to be deleted

Backend Code Generation Impact

No impact

Desired Merge Strategy

  • Squash

Release Notes

[bugfix] MustDeduplicateAnnotation no longer throws an exception when targets are deleted.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@jackkoenig jackkoenig added this to the 1.4.x milestone May 4, 2021
@jackkoenig jackkoenig force-pushed the must-dedup-can-delete branch from 66ba33b to 39fa652 Compare May 4, 2021 19:47
@jackkoenig jackkoenig merged commit 6db311b into master May 4, 2021
@jackkoenig jackkoenig deleted the must-dedup-can-delete branch May 4, 2021 20:19
mergify bot pushed a commit that referenced this pull request May 4, 2021
@mergify mergify bot added the Backported This PR has been backported to marked stable branch label May 4, 2021
mergify bot added a commit that referenced this pull request May 4, 2021
(cherry picked from commit 6db311b)

Co-authored-by: Jack Koenig <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Backported This PR has been backported to marked stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants