WiringTransform: cannot run after RemoveWires

[ekiwi]

The problem this is trying to address is that I sometimes get pass orderings where RemoveWires runs before the Wiring transform and that gets a wiring target turned from a Wire into a Node which Wiring then fails to deal with properly.

Contributor Checklist

• Did you add at least one test demonstrating the PR?
• Did you delete any extraneous printlns/debugging code?
• Did you specify the type of improvement?
• Did you state the API impact?
• Did you specify the code generation impact?
• Did you request a desired merge strategy?
• Did you add text to be included in the Release Notes for this change?

Type of Improvement

• bug fix

API Impact

• none

Backend Code Generation Impact

• none

Desired Merge Strategy

• squash

Reviewer Checklist (only modified by reviewer)

• Did you add the appropriate labels?
• Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
• Did you review?
• Did you check whether all relevant Contributor checkboxes have been checked?
• Did you mark as Please Merge?

[ekiwi]

This should fix #2208

[seldridge]

Looks great! Thanks for fixing this, @ekiwi.

[ekiwi]

Thanks! Let's not backport this, just in case it has unintended consequences or breaks someone's flow.